From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH v5] ndctl: add option to list firmware information for a DIMM
Date: Fri, 16 Feb 2018 16:14:16 -0800 [thread overview]
Message-ID: <CAPcyv4jLmj8s3-0tveTQWyoSW1p39vNS2_OiJer3k1ufMJb6pw@mail.gmail.com> (raw)
In-Reply-To: <151882591629.8048.11430473366131999791.stgit@djiang5-desk3.ch.intel.com>
On Fri, Feb 16, 2018 at 4:07 PM, Dave Jiang <dave.jiang@intel.com> wrote:
> Adding firmware output of firmware information when ndctl list -D -F is used.
> Components displayed are current firmware version, updated firmware version,
> and if a coldboot is required (firmware updated).
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Tested-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> v5:
> - Changed next_version to updated version to be in sync with DSM spec.
> - Changed emission of "unknown" string to -1 for error versions.
>
> v4:
> - Remove output when updated_version is 0. That indicates no updated firmware.
>
> v3:
> - Fixed issue where it skips displaying rest of the details if there's no
> firmware details.
>
> v2:
> - Added copyright
> - Added support for human readable option (hex) for versions
> - Removed check against CMD_CALL as it's not useful
>
> Documentation/ndctl/ndctl-list.txt | 13 +++++
> ndctl/Makefile.am | 1
> ndctl/list.c | 13 +++++
> ndctl/util/json-firmware.c | 91 ++++++++++++++++++++++++++++++++++++
> util/json.h | 2 +
> 5 files changed, 120 insertions(+)
> create mode 100644 ndctl/util/json-firmware.c
>
> diff --git a/Documentation/ndctl/ndctl-list.txt b/Documentation/ndctl/ndctl-list.txt
> index fc07a71..85b87d4 100644
> --- a/Documentation/ndctl/ndctl-list.txt
> +++ b/Documentation/ndctl/ndctl-list.txt
> @@ -110,6 +110,19 @@ include::xable-region-options.txt[]
> }
> }
>
> +-F::
> +--firmware::
> + Include dimm firmware info in the listing. For example:
> +[verse]
> +{
> + "dev":"nmem0",
> + "firmware":{
> + "current_version":0,
> + "next_version":1,
> + "coldboot_required":true
> + }
Sorry for the bikeshedding, but I think 'next_version' is more clear
than 'updated_version' and 'coldboot_required' should be
'need_powercycle'.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-02-17 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 0:07 [PATCH v5] ndctl: add option to list firmware information for a DIMM Dave Jiang
2018-02-17 0:14 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jLmj8s3-0tveTQWyoSW1p39vNS2_OiJer3k1ufMJb6pw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).