From: Dan Williams <dan.j.williams@intel.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 2/2] ndctl: add "all" dimm-id option for update-firmware
Date: Wed, 21 Feb 2018 15:56:59 -0800 [thread overview]
Message-ID: <CAPcyv4jUPddTPvZhKXjV54xLgWKdOFm5Jvzff5bbvwT0q2gggg@mail.gmail.com> (raw)
In-Reply-To: <1519252098.24924.23.camel@intel.com>
On Wed, Feb 21, 2018 at 2:28 PM, Verma, Vishal L
<vishal.l.verma@intel.com> wrote:
>
> On Wed, 2018-02-21 at 15:06 -0700, Dave Jiang wrote:
>> Adding all option to allow ndctl to update all DIMMs at once.
>
> I was going to ask that we should also update the documentation for
> this command to include the new 'all' behavior, but it looks like
> during the revisions of the original series, the documentation update
> to list the options explicitly got dropped?
>
> Anyway, can you re-add those, and also talk about --dimm=all there.
>
> On a side note, should we make this more inline with other dimm
> commands, such as xable-dimm or read/write-labels, where the dimm name
> (or 'all') is a non-option argument? That would make it something like:
>
> ndctl update-firmware --firmware=<file> nmem0 (or 'all)
Sounds good to me, but we should still silently support -d for just
this command since it appeared in a released version and user
interfaces are forever.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-02-21 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 22:05 [PATCH 1/2] ndctl: add more error outs to update firmware and enable verbose debug Dave Jiang
2018-02-21 22:06 ` [PATCH 2/2] ndctl: add "all" dimm-id option for update-firmware Dave Jiang
2018-02-21 22:28 ` Verma, Vishal L
2018-02-21 23:56 ` Dan Williams [this message]
2018-02-21 23:52 ` Dan Williams
2018-02-21 23:59 ` [PATCH 1/2] ndctl: add more error outs to update firmware and enable verbose debug Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jUPddTPvZhKXjV54xLgWKdOFm5Jvzff5bbvwT0q2gggg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).