From: Peter Zijlstra <peterz@infradead.org>
To: kajoljain <kjain@linux.ibm.com>
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
maddy@linux.vnet.ibm.com, aneesh.kumar@linux.ibm.com,
vaibhav@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
tglx@linutronix.de
Subject: Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats
Date: Fri, 14 May 2021 13:47:15 +0200 [thread overview]
Message-ID: <YJ5jQ1ixz7D0Ij2R@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <37015d53-050a-acef-2958-b1ff5d02800b@linux.ibm.com>
On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote:
> But yes the current read/add/del functions are not adding value. We
> could add an arch/platform specific function which could handle the
> capturing of the counter data and do the rest of the operation here,
> is this approach better?
Right; have your register_nvdimm_pmu() set pmu->{add,del,read} to
nd_pmu->{add,del,read} directly, don't bother with these intermediates.
Also you can WARN_ON_ONCE() if any of them are NULL and fail
registration at that point.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-05-14 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 16:38 [RFC 0/4] Add perf interface to expose nvdimm performance stats Kajol Jain
2021-05-12 16:38 ` [RFC 1/4] drivers/nvdimm: " Kajol Jain
2021-05-12 17:27 ` Peter Zijlstra
2021-05-13 12:26 ` kajoljain
2021-05-14 11:47 ` Peter Zijlstra [this message]
2021-05-17 6:43 ` kajoljain
2021-05-12 16:38 ` [RFC 2/4] powerpc/papr_scm: Add perf interface support Kajol Jain
2021-05-12 16:38 ` [RFC 3/4] powerpc/papr_scm: Document papr_scm sysfs event format entries Kajol Jain
2021-05-12 16:38 ` [RFC 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ5jQ1ixz7D0Ij2R@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=tglx@linutronix.de \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox