From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 1/1] nvdimm: use the right length of "pmem"
Date: Sun, 30 Oct 2016 17:57:10 +0100 [thread overview]
Message-ID: <a632b81f-c33d-e506-c9e6-762a5c7f6c3f@m4x.org> (raw)
In-Reply-To: <CAPcyv4hwQQsZg-FG0h1yH-h4OsAe_Nd=-1=L9f-Zev2vUSHj2w@mail.gmail.com>
On 30/10/16 16:50, Dan Williams wrote:
> On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
> <nicolas.iooss_linux@m4x.org> wrote:
>> In order to test that the name of a resource begins with "pmem", call
>> strncmp() with 4 as length instead of 3 to match the whole prefix.
>>
>> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
>> for multi-pmem")
>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
>
> Thanks, although I would not call this out as a fix since the length
> parameter could be 1 and still do the right thing. I.e. we're
> distinguishing "blk" from "pmem" resources. I'll add this for 4.10 as
> a cleanup.
All right. Thanks for your quick reply!
Nicolas
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2016-10-30 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 11:28 [PATCH 1/1] nvdimm: use the right length of "pmem" Nicolas Iooss
2016-10-30 15:50 ` Dan Williams
2016-10-30 16:57 ` Nicolas Iooss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a632b81f-c33d-e506-c9e6-762a5c7f6c3f@m4x.org \
--to=nicolas.iooss_linux@m4x.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).