From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8209281CEA for ; Sun, 30 Oct 2016 09:57:13 -0700 (PDT) Received: by mail-wm0-f68.google.com with SMTP id 68so8379048wmz.2 for ; Sun, 30 Oct 2016 09:57:14 -0700 (PDT) Subject: Re: [PATCH 1/1] nvdimm: use the right length of "pmem" References: <20161029112852.19975-1-nicolas.iooss_linux@m4x.org> From: Nicolas Iooss Message-ID: Date: Sun, 30 Oct 2016 17:57:10 +0100 MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On 30/10/16 16:50, Dan Williams wrote: > On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss > wrote: >> In order to test that the name of a resource begins with "pmem", call >> strncmp() with 4 as length instead of 3 to match the whole prefix. >> >> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation >> for multi-pmem") >> Signed-off-by: Nicolas Iooss > > Thanks, although I would not call this out as a fix since the length > parameter could be 1 and still do the right thing. I.e. we're > distinguishing "blk" from "pmem" resources. I'll add this for 4.10 as > a cleanup. All right. Thanks for your quick reply! Nicolas _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm