From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Oliver O'Halloran <oohall@gmail.com>,
Markus Elfring <Markus.Elfring@web.de>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c
Date: Wed, 19 Aug 2020 22:18:23 +0800 [thread overview]
Message-ID: <aacaa4e4-95c9-c089-dea0-6a7c4808d1ea@huawei.com> (raw)
In-Reply-To: <CAOSf1CGJ6JNBuN+EpLttpf0HYOtN8dpqoTscGYHEbxqb9ANkVg@mail.gmail.com>
On 8/19/2020 9:35 PM, Oliver O'Halloran wrote:
> On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>>
>>> The memory priv->bus_desc.provider_name allocated by kstrdup() is not
>>> freed correctly.
>
> Personally I thought his commit message was perfectly fine. A little
> unorthodox, but it works.
>
>> How do you think about to choose an imperative wording for
>> a corresponding change description?
>
> ...but this! This is word salad.
Talented students are trained by strict teacher. All of us is trying to make things better.
>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>>
>> Regards,
>> Markus
>
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-08-19 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 2:04 [PATCH v2 0/4] bugfix and optimize for drivers/nvdimm Zhen Lei
2020-08-19 2:05 ` [PATCH v2 1/4] libnvdimm: fix memmory leaks in of_pmem.c Zhen Lei
2020-08-19 12:28 ` [PATCH v2 1/4] libnvdimm: Fix memory " Markus Elfring
2020-08-19 13:34 ` Leizhen (ThunderTown)
2020-08-19 13:35 ` Oliver O'Halloran
2020-08-19 14:18 ` Leizhen (ThunderTown) [this message]
2020-08-19 13:37 ` [PATCH v2 1/4] libnvdimm: fix memmory " Oliver O'Halloran
2020-08-19 14:19 ` Leizhen (ThunderTown)
2020-08-19 2:05 ` [PATCH v2 2/4] libnvdimm: add sanity check for provider_name in of_pmem_region_probe() Zhen Lei
2020-08-19 2:05 ` [PATCH v2 3/4] libnvdimm/bus: simplify walk_to_nvdimm_bus() Zhen Lei
2020-08-19 12:40 ` Markus Elfring
2020-08-19 13:35 ` Leizhen (ThunderTown)
2020-08-19 2:05 ` [PATCH v2 4/4] libnvdimm/region: reduce an unnecessary if branch in nd_region_create() Zhen Lei
2020-08-19 12:20 ` [PATCH v2 0/4] bug fix and optimize for drivers/nvdimm Markus Elfring
2020-08-19 13:30 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacaa4e4-95c9-c089-dea0-6a7c4808d1ea@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox