From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD6CB2130D7EF for ; Mon, 12 Aug 2019 14:22:38 -0700 (PDT) Subject: Re: [RFC PATCH v2 15/19] mm/gup: Introduce vaddr_pin_pages() References: <20190809225833.6657-1-ira.weiny@intel.com> <20190809225833.6657-16-ira.weiny@intel.com> <6ed26a08-4371-9dc1-09eb-7b8a4689d93b@nvidia.com> <20190812210013.GC20634@iweiny-DESK2.sc.intel.com> From: John Hubbard Message-ID: Date: Mon, 12 Aug 2019 14:20:14 -0700 MIME-Version: 1.0 In-Reply-To: <20190812210013.GC20634@iweiny-DESK2.sc.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ira Weiny Cc: Michal Hocko , Theodore Ts'o , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, Matthew Wilcox , linux-xfs@vger.kernel.org, Jason Gunthorpe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Jan Kara , Andrew Morton , linux-ext4@vger.kernel.org List-ID: On 8/12/19 2:00 PM, Ira Weiny wrote: > On Fri, Aug 09, 2019 at 05:09:54PM -0700, John Hubbard wrote: >> On 8/9/19 3:58 PM, ira.weiny@intel.com wrote: >>> From: Ira Weiny ... > > At one point I wanted to (and had in my tree) a new flag but I went away from > it. Prior to the discussion on mlock last week I did not think we needed it. > But I'm ok to add it back in. > > I was not ignoring the idea for this RFC I just wanted to get this out there > for people to see. I see that you threw out a couple of patches which add this > flag in. > > FWIW, I think it would be good to differentiate between an indefinite pinned > page vs a referenced "gotten" page. > > What you and I have been working on is the former. So it would be easy to > change your refcounting patches to simply key off of FOLL_PIN. > > Would you like me to add in your FOLL_PIN patches to this series? Sure, that would be perfect. They don't make any sense on their own, and it's all part of the same design idea. thanks, -- John Hubbard NVIDIA _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm