From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B005E213030AC for ; Fri, 2 Aug 2019 11:04:26 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [ndctl PATCH v2 01/26] ndctl/dimm: Add 'flags' field to read-labels output Date: Fri, 2 Aug 2019 18:01:54 +0000 Message-ID: References: <156426356088.531577.14828880045306313118.stgit@dwillia2-desk3.amr.corp.intel.com> <156426356654.531577.6142389862764297120.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <156426356654.531577.6142389862764297120.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" List-ID: On Sat, 2019-07-27 at 14:39 -0700, Dan Williams wrote: > Recent discussions on some platform implementations setting the LOCAL > bit in namespace labels makes it apparent that this field should be > decoded in the json representation. > > Signed-off-by: Dan Williams > --- > ndctl/dimm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/ndctl/dimm.c b/ndctl/dimm.c > index b2b09b6aa9a2..8946dc74fe41 100644 > --- a/ndctl/dimm.c > +++ b/ndctl/dimm.c > @@ -141,6 +141,11 @@ static struct json_object *dump_label_json(struct ndctl_dimm *dimm, > break; > json_object_object_add(jlabel, "nlabel", jobj); > > + jobj = json_object_new_int64(le64_to_cpu(nslabel.flags)); Should we print this in hex instead? > + if (!jobj) > + break; > + json_object_object_add(jlabel, "flags", jobj); > + > jobj = json_object_new_int64(le64_to_cpu(nslabel.isetcookie)); > if (!jobj) > break; > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm