From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH V1 1/2] libnvdimm/nsio: differentiate between probe mapping and runtime mapping
Date: Thu, 17 Oct 2019 08:48:40 +0530 [thread overview]
Message-ID: <d99770e8-ae29-c38f-9daf-6965d5eab2cb@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4grR0o5jRH+hqPNqDW8rCmU4bUfctzPxGUg+mZN9h_8TQ@mail.gmail.com>
On 10/17/19 8:34 AM, Dan Williams wrote:
> On Wed, Oct 16, 2019 at 7:43 PM Aneesh Kumar K.V
....
>>>
>> The error is printed by generic code and the failures are due to fixed
>> size. We can't workaround that using vmalloc=<size> option.
>
> Darn.
>
> Ok, explain to me again how this patch helps. This just seems to delay
> the inevitable failure a bit, but the end result is that the user
> needs to pick and choose which namespaces to enable after the kernel
> has tried to auto-probe namespaces.
>
Right now we map the entire namespace using I/O remap range while
probing and if we find the namespace mode to be fsdax or devdax we unmap
the namespace and map them back using direct-map range. This temporary
mapping cause transient failures if two large namespaces were probed at
the same time. We try to map the second names space in the I/O remap
range while the first one is already mapped there. ie,
If we have two 6TB namespaces with an I/O remap range limit of 8TB. We
can individually create these namespaces and enable/disable them because
they are within the 8TB limit. But if we try to probe them together,
and if namespace1 is already mapped in the I/O remap range we have only
2TB space left in the I/O remap range and trying to probe the second
namespace at the same time fails due to lack of space to map the
namespace during probing.
This is not an issue with raw/btt, because they keep the namespace
always mapped in the I/O remap range and if we are able to create a
namespace we can enable them together. (we do have the issue of creating
large raw/btt namespace while other raw/btt namespaces are disabled and
trying to enable them all together).
The fix proposed in this patch is to not map the full namespace range
while probing. We just need to map the reserve block to find the
namespace mode. Based on the detected namespace mode, we either use
direct-map range or I/O range to map the full namespace.
-aneesh
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-10-17 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:33 [PATCH V1 1/2] libnvdimm/nsio: differentiate between probe mapping and runtime mapping Aneesh Kumar K.V
2019-10-15 15:33 ` [PATCH V1 2/2] libnvdimm/nsio: Rename devm_nsio_enable/disable to devm_nsio_probe_enable/disable Aneesh Kumar K.V
2019-10-15 22:02 ` [PATCH V1 1/2] libnvdimm/nsio: differentiate between probe mapping and runtime mapping Dan Williams
2019-10-16 5:29 ` Aneesh Kumar K.V
2019-10-16 16:04 ` Dan Williams
2019-10-16 16:58 ` Aneesh Kumar K.V
2019-10-16 19:05 ` Dan Williams
2019-10-17 2:43 ` Aneesh Kumar K.V
2019-10-17 3:04 ` Dan Williams
2019-10-17 3:18 ` Aneesh Kumar K.V [this message]
2019-10-17 4:12 ` Dan Williams
2019-10-17 7:10 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99770e8-ae29-c38f-9daf-6965d5eab2cb@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox