From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CDE90222EDCE6 for ; Thu, 4 Jan 2018 16:15:33 -0800 (PST) References: <20180104190137.7654-1-logang@deltatee.com> <20180104190137.7654-2-logang@deltatee.com> <20180104215941.GG189897@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: Date: Thu, 4 Jan 2018 17:20:19 -0700 MIME-Version: 1.0 In-Reply-To: <20180104215941.GG189897@bhelgaas-glaptop.roam.corp.google.com> Content-Language: en-US Subject: Re: [PATCH 01/12] pci-p2p: Support peer to peer memory List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Bjorn Helgaas Cc: Jens Axboe , Keith Busch , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On 04/01/18 02:59 PM, Bjorn Helgaas wrote: > On Thu, Jan 04, 2018 at 12:01:26PM -0700, Logan Gunthorpe wrote: >> Some PCI devices may have memory mapped in a BAR space that's >> intended for use in Peer-to-Peer transactions. In order to enable >> such transactions the memory must be registered with ZONE_DEVICE pages >> so it can be used by DMA interfaces in existing drivers. >> ... > >> + * pci_p2pmem_alloc_sgl - allocate p2p memory in an sgl >> + * @pdev: the device to allocate memory from >> + * @sgl: the allocated sgl >> + * @nents: the number of sgs in the list >> + * @length: number of bytes to allocate > > Your later patches use "SGL" in English text. If that's the conventional > capitalization, please use it here, too. > I'm not sure there is a convention. scatterlist.h uses 'sglist' and 'scatterlist' so I'll just change my comments to use the latter. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm