linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH] ndctl: add option to list firmware information for a DIMM
Date: Tue, 13 Feb 2018 08:25:04 -0500	[thread overview]
Message-ID: <x497erhqaxb.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <151848066201.13592.3757378386488366418.stgit@djiang5-desk3.ch.intel.com> (Dave Jiang's message of "Mon, 12 Feb 2018 17:11:02 -0700")

Hi, Dave,

Dave Jiang <dave.jiang@intel.com> writes:

> Adding firmware output of firmware information when ndctl list -D -F is used.
> Components displayed are current firmware version, updated firmware version,
> and if a coldboot is required (firmware updated).
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  Documentation/ndctl/ndctl-list.txt |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> @@ -420,6 +422,25 @@ int cmd_list(int argc, const char **argv, void *ctx)
>  				}
>  			}
>  
> +			if (list.firmware) {
> +				struct json_object *jfirmware;
> +
> +				jfirmware = util_dimm_firmware_to_json(dimm);
> +				if (jfirmware)
> +					json_object_object_add(jdimm,
> +							"firmware",
> +							jfirmware);
> +				else if (ndctl_dimm_is_cmd_supported(dimm,
> +							ND_CMD_CALL)) {
> +					/*
> +					 * Failed to retrieve firmware
> +					 * version.
> +					 */
> +					fail("\n");

I'm hitting this failure.  Also, you might consider adding some text,
there.  :)

-Jeff
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      reply	other threads:[~2018-02-13 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  0:11 [PATCH] ndctl: add option to list firmware information for a DIMM Dave Jiang
2018-02-13 13:25 ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x497erhqaxb.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).