From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Dan J. Williams" <dan.j.williams@intel.com>,
linux-nvdimm@ml01.01.org, linux-block@vger.kernel.org
Subject: Re: [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events
Date: Wed, 09 Nov 2016 14:31:30 -0500 [thread overview]
Message-ID: <x49mvh8o3fx.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20161109191715.GA20314@infradead.org> (Christoph Hellwig's message of "Wed, 9 Nov 2016 11:17:15 -0800")
Christoph Hellwig <hch@infradead.org> writes:
> On Wed, Nov 09, 2016 at 02:08:33PM -0500, Jeff Moyer wrote:
>> Right now, any of the above three drivers will report Q events in
>> blktrace but no corresponding C events. Fix it.
>
> It seems like that trace point should simply go into bio_endio
> and be removed from any existing callsite.
bio_endio is still called for request_fn drivers, so you'd see two
completion events for those drivers if we did that, no?
-Jeff
next prev parent reply other threads:[~2016-11-09 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:08 [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events Jeff Moyer
[not found] ` <x49twbgo4i6.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2016-11-09 19:17 ` Christoph Hellwig
2016-11-09 19:31 ` Jeff Moyer [this message]
[not found] ` <x49mvh8o3fx.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2016-11-09 19:34 ` Christoph Hellwig
2016-11-09 19:43 ` Jeff Moyer
2016-11-10 19:33 ` Christoph Hellwig
2016-11-11 14:55 ` Jeff Moyer
2016-11-16 4:56 ` Ross Zwisler
2016-11-16 14:06 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49mvh8o3fx.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).