From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH] nvme-rdma: Always signal fabrics private commands
Date: Wed, 13 Jul 2016 09:28:07 -0500 [thread overview]
Message-ID: <001f01d1dd12$c5fb8500$51f28f00$@opengridcomputing.com> (raw)
In-Reply-To: <578613C8.7030005@grimberg.me>
>
> > Hi Steve,
> >
> > Sorry for the late response, I was on vacation.
> >
> > The patch looks fine,
> >
> > Reviewed-by: Sagi Grimberg <sagi at imberg.me>
>
> Although, I think that we really should fix the
> double completion for unsignaled wqes in cxgb4...
> it might bite us elsewhere down the road.
Double completion? When the QP exits RTS with pending unsignaled SQ WRs, cxgb4
doesn't know if those were actually completed by hardware, so they are completed
with FLUSH_ERR status. I _could_ change cxgb4 to just eat those, but I'm a
little worried about breaking the iWARP Verbs semantics. Perhaps I shouldn't
be. It does seem to be causing lots of pain...
next prev parent reply other threads:[~2016-07-13 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 16:08 [PATCH] nvme-rdma: Always signal fabrics private commands Sagi Grimberg
2016-06-23 18:17 ` Steve Wise
2016-06-24 7:07 ` Christoph Hellwig
2016-06-24 14:05 ` Steve Wise
2016-06-26 16:41 ` Sagi Grimberg
2016-06-28 8:41 ` Christoph Hellwig
2016-06-28 14:20 ` Steve Wise
2016-06-29 14:57 ` Steve Wise
2016-06-30 6:36 ` 'Christoph Hellwig'
2016-06-30 13:44 ` Steve Wise
2016-06-30 15:10 ` Steve Wise
2016-07-13 10:08 ` Sagi Grimberg
2016-07-13 10:11 ` Sagi Grimberg
2016-07-13 14:28 ` Steve Wise [this message]
2016-07-13 14:47 ` Sagi Grimberg
2016-07-13 14:51 ` Steve Wise
2016-07-13 15:02 ` Sagi Grimberg
2016-07-13 15:12 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001f01d1dd12$c5fb8500$51f28f00$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).