From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Bryan Gurney <bgurney@redhat.com>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "alan.adamson@oracle.com" <alan.adamson@oracle.com>,
"bvanassche@acm.org" <bvanassche@acm.org>
Subject: Re: [PATCH blktests v2] nvme/039: check for logical block size of test device
Date: Wed, 27 Nov 2024 07:49:58 +0000 [thread overview]
Message-ID: <002e624b-ced9-4251-922c-e41bf5966d90@nvidia.com> (raw)
In-Reply-To: <20241125193933.22017-1-bgurney@redhat.com>
On 11/25/24 11:39, Bryan Gurney wrote:
> This test has hard-coded 512 byte values for the dd commands, which
> will fail on 4096-byte block devices. Create an LB_SZ global
> variable that is populated with the result of the command
> "blockdev --getss <dev>", and use that result for the block size
> of the write commands.
>
> Also use this variable for the "--data-len" command of the "nvme
> admin-passthru" and "nvme io-passthru" tests. (On a test with a
> 4096-byte namespace, leaving these with the hardcoded values still
> passed, but update them for the sake of consistency.)
>
> Signed-off-by: Bryan Gurney<bgurney@redhat.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-11-27 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 19:39 [PATCH blktests v2] nvme/039: check for logical block size of test device Bryan Gurney
2024-11-25 23:44 ` alan.adamson
2024-11-27 7:49 ` Chaitanya Kulkarni [this message]
2024-11-28 1:03 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002e624b-ced9-4251-922c-e41bf5966d90@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=alan.adamson@oracle.com \
--cc=bgurney@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox