From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH WIP/RFC v3 5/6] nvme-rdma: add DELETING queue flag
Date: Thu, 1 Sep 2016 08:34:23 -0500 [thread overview]
Message-ID: <004501d20455$8d3a38a0$a7aea9e0$@opengridcomputing.com> (raw)
In-Reply-To: <20160901084101.GE3703@lst.de>
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch at lst.de]
> Sent: Thursday, September 01, 2016 3:41 AM
> To: swise at opengridcomputing.com; Sagi Grimberg
> Cc: hch at lst.de; linux-nvme at lists.infradead.org
> Subject: Re: [PATCH WIP/RFC v3 5/6] nvme-rdma: add DELETING queue flag
>
> Steve,
>
> this mail pretends to be from Sagi, which given the threading looks
> unlikely. Can you fix up your patch mail scripts so that it appears
> from you and has another
>
> From: Sagi Grimberg <sagi at grimberg.me>
>
> line in the mail body?
Yes, I screwed up here. I'll fix it in v4.
>
> > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> > index c2f6cc6..8036c23 100644
> > --- a/drivers/nvme/host/rdma.c
> > +++ b/drivers/nvme/host/rdma.c
> > @@ -88,6 +88,7 @@ struct nvme_rdma_request {
> > enum nvme_rdma_queue_flags {
> > NVME_RDMA_Q_CONNECTED = (1 << 0),
> > NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1),
> > + NVME_RDMA_Q_DELETING = (1 << 2),
>
> Can we please aligned these now that we have a few?
>
> NVME_RDMA_Q_CONNECTED = (1 << 0),
> NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1),
> NVME_RDMA_Q_DELETING = (1 << 2),
>
>
> Otherwise this looks fine:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2016-09-01 13:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 16:26 [PATCH WIP/RFC v3 0/6] nvme-rdma device removal fixes Steve Wise
2016-08-29 21:26 ` [PATCH WIP/RFC v3 1/6] iw_cxgb4: call dev_put() on l2t allocation failure Steve Wise
2016-09-01 8:34 ` Christoph Hellwig
2016-08-29 21:26 ` [PATCH WIP/RFC v3 2/6] iw_cxgb4: block module unload until all ep resources are released Steve Wise
2016-09-01 8:35 ` Christoph Hellwig
2016-08-29 21:27 ` [PATCH WIP/RFC v3 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush Steve Wise
2016-08-30 17:24 ` Sagi Grimberg
2016-08-30 17:48 ` Steve Wise
2016-08-31 5:06 ` Sagi Grimberg
2016-08-31 14:29 ` Steve Wise
2016-09-01 6:40 ` Sagi Grimberg
2016-09-01 8:36 ` Christoph Hellwig
2016-09-01 9:31 ` Sagi Grimberg
2016-08-29 21:28 ` [PATCH WIP/RFC v3 5/6] nvme-rdma: add DELETING queue flag Sagi Grimberg
2016-09-01 8:41 ` Christoph Hellwig
2016-09-01 13:34 ` Steve Wise [this message]
2016-08-29 21:28 ` [PATCH WIP/RFC v3 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure Steve Wise
2016-09-01 15:00 ` Steve Wise
2016-08-30 16:25 ` [PATCH WIP/RFC v3 6/6] nvme-rdma: use ib_client API to detect device removal Steve Wise
2016-09-01 8:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004501d20455$8d3a38a0$a7aea9e0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).