From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH 0/1] Fix for nvme-rdma host crash in nvmf-all.3
Date: Thu, 23 Jun 2016 08:59:56 -0500 [thread overview]
Message-ID: <004f01d1cd57$85fc0530$91f40f90$@opengridcomputing.com> (raw)
In-Reply-To: <576B8FB7.5000305@grimberg.me>
>
> > This patch fixes a touch-after-free bug I discovered. It is against
> > nvmf-all.3 branch of git://git.infradead.org/nvme-fabrics.git. The patch
> > is kind of ugly, so any ideas on a cleaner solution are welcome.
>
> Hey Steve, I don't see how this bug fixes the root-cause. Not exactly
> sure we understand the root-cause. Is it possible that this is a chelsio
> specific issue with send completion signaling (like we saw before)? Did
> this happen with a non-chelsio device?
Due to the stack trace, I believe this is a similar issue we saw before. It is
probably chelsio-specific. I don't see it on mlx4.
The fix for the previous occurrence of this crash was to signal all FLUSH
commands. Do you recall why that fixed it? Perhaps this failure path needs
some other signaled command to force the pending unsignaled WRs to be marked
"complete" by the driver?
Steve.
next prev parent reply other threads:[~2016-06-23 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 20:14 [PATCH 0/1] Fix for nvme-rdma host crash in nvmf-all.3 Steve Wise
2016-06-22 20:14 ` [PATCH 1/1] nvme-rdma: correctly unwind on bad subsystemnqn error Steve Wise
2016-06-23 7:28 ` [PATCH 0/1] Fix for nvme-rdma host crash in nvmf-all.3 Sagi Grimberg
2016-06-23 13:59 ` Steve Wise [this message]
2016-06-23 15:50 ` Sagi Grimberg
2016-06-23 15:59 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004f01d1cd57$85fc0530$91f40f90$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).