From mboxrd@z Thu Jan  1 00:00:00 1970
From: s.chawdhary@samsung.com (Swati)
Date: Tue, 04 Nov 2014 20:11:08 +0530
Subject: [PATCH] nvme-user: Minor enhancement and fixes
In-Reply-To: <alpine.LNX.2.00.1410301321520.4225@localhost.lm.intel.com>
References: <1414664449-3288-1-git-send-email-s.chawdhary@samsung.com>
 <alpine.LNX.2.00.1410301321520.4225@localhost.lm.intel.com>
Message-ID: <005601cff83d$63f09b40$2bd1d1c0$@samsung.com>

Hi Keith,

>>  - During Format, if LBA Format Metadata Size(MS) is 0, set Metadata
Settings to Extended LBA.

> Why? This is what sets identify namespace's FLBAS bit 4. The 1.1b spec
clarified this bit is not applicable when metadata size is 0.

As this was not clear before the 1.1b Spec, we have f/w where, if Metadata
Size is 0 and this bit is not set, the format command fails with error
status code Ah (enabling metadata to be transferred as part of a separate
buffer when there is no metadata supported as part of the format selected)

So can we have metadata handling, based on the spec version supported by the
device? 
The code can be changed something like this -

if(NVME_PRPTO_VER_1.1b) {
	...
} else{
	...
} 

I will resubmit the changes based on your opinion.  
Also do you need a separate patch for the Secure Erase Settings(SES)
support?

Regards,
Swati