From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH] nvme-rdma: Fix early queue flags settings
Date: Wed, 21 Sep 2016 10:10:14 -0500 [thread overview]
Message-ID: <007101d2141a$4179eb20$c46dc160$@opengridcomputing.com> (raw)
In-Reply-To: <005e01d21417$cb514530$61f3cf90$@opengridcomputing.com>
> > Sagi, you originally proposed this in a patch for debugging the crash
> where
> > a request is accessing a queue with rdma resources freed:
> >
> > @@ -542,11 +542,12 @@ static int nvme_rdma_create_queue_ib(struct
> > nvme_rdma_queue *queue,
> > goto out_destroy_qp;
> > }
> > set_bit(NVME_RDMA_IB_QUEUE_ALLOCATED, &queue->flags);
> > + clear_bit(NVME_RDMA_Q_DELETING, &queue->flags);
> >
> > return 0;
> >
> >
> > Perhaps this is how we should proceed?
>
> Just tested this, and it doesn't fix the problem. This makes sense,
because
> we really only want to clear it if we successfully setup the connection...
> So never mind. :)
What I'm trying to say is that if you use clear_bit(), it needs to be
exactly where the flags = 0 was.
Thanks,
Steve.
next prev parent reply other threads:[~2016-09-21 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 18:57 [PATCH] nvme-rdma: Fix early queue flags settings Sagi Grimberg
2016-09-20 19:01 ` Steve Wise
2016-09-20 19:05 ` Sagi Grimberg
2016-09-20 20:08 ` Christoph Hellwig
2016-09-20 20:14 ` Steve Wise
2016-09-21 3:38 ` Sagi Grimberg
2016-09-21 14:01 ` 'Christoph Hellwig'
2016-09-21 14:18 ` Steve Wise
2016-09-21 14:52 ` Steve Wise
2016-09-21 15:10 ` Steve Wise [this message]
2016-09-21 14:36 ` Sagi Grimberg
2016-09-21 15:50 ` Steve Wise
2016-09-21 19:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007101d2141a$4179eb20$c46dc160$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).