Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sunad.s@samsung.com (Sunad Bhandary)
Subject: [PATCHv3] NVMe: write_long SCSI to NVMe translation implementation
Date: Thu, 16 Apr 2015 17:34:00 +0530	[thread overview]
Message-ID: <00aa01d0783d$712a4c40$537ee4c0$@samsung.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1503241353070.32385@localhost.lm.intel.com>

Hi Keith,

I see that this has not been committed yet. Are any changes needed to the
patch from my side ?

Thanks and regards,
Sunad 

-----Original Message-----
From: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On Behalf
Of Keith Busch
Sent: Tuesday, March 24, 2015 7:25 PM
To: Sunad Bhandary
Cc: keith.busch at intel.com; linux-nvme at lists.infradead.org
Subject: RE: [PATCHv3] NVMe: write_long SCSI to NVMe translation
implementation

Hi Sunad,

On Tue, 24 Mar 2015, Sunad Bhandary wrote:
> Hi Keith,
>
> I think this patch suffices for the shortcomings of the previous versions.
> Does anything else seem amiss ?
>
> If I am to submit a version of the patch for the legacy-nvme , the 
> SCSI macro SERVICE_ACTION _OUT_16 is not present in the kernel.
> Is it alright to define a Macro  SAO_16(0x9f)  exclusive to nvme-scsi 
> to support WRITE_LONG_16?

Sounds good. Patch v3 looks good to me as well.

Thanks,
Keith

> From: Sunad Bhandary S <sunad.s at samsung.com>
>
> This patch implements the SCSI to NVMe translation for write_long.
> write_long is translated to the NVMe command write_uncorrectable as 
> defined by the translation specification version 1.4.
>
> This patch also indicates the device support for write_uncorrectable 
> method in the response of extended inquiry as defined in the translation
spec.

Acked-by: Keith Busch <keith.busch at intel.com>

> Signed-off-by: Sunad Bhandary S <sunad.s at samsung.com>

_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2015-04-16 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 13:48 [PATCHv3] NVMe: write_long SCSI to NVMe translation implementation Sunad Bhandary S
2015-03-24 11:57 ` Sunad Bhandary
2015-03-24 13:54   ` Keith Busch
2015-04-16 12:04     ` Sunad Bhandary [this message]
2015-04-16 14:27       ` Keith Busch
2015-03-24 16:23 ` Matthew Wilcox
2015-03-24 16:36   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00aa01d0783d$712a4c40$537ee4c0$@samsung.com' \
    --to=sunad.s@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox