linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support
Date: Mon, 4 Jun 2018 09:21:16 -0500	[thread overview]
Message-ID: <019101d3fc0f$4d32a4f0$e797eed0$@opengridcomputing.com> (raw)
In-Reply-To: <05438bc4-61a0-e4ca-a00d-d918c20a0dcc@mellanox.com>



> -----Original Message-----
> From: Max Gurtovoy <maxg at mellanox.com>
> Sent: Monday, June 4, 2018 8:52 AM
> To: Christoph Hellwig <hch at lst.de>; Sagi Grimberg <sagi at grimberg.me>
> Cc: Steve Wise <swise at opengridcomputing.com>; 'Ruhl, Michael J'
> <michael.j.ruhl at intel.com>; axboe at kernel.dk; 'Busch, Keith'
> <keith.busch at intel.com>; linux-nvme at lists.infradead.org;
> parav at mellanox.com; linux-rdma at vger.kernel.org
> Subject: Re: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed
sgl
> support
> 
> 
> 
> On 6/4/2018 3:11 PM, Christoph Hellwig wrote:
> > On Mon, Jun 04, 2018@03:01:43PM +0300, Sagi Grimberg wrote:
> >>
> >>> He's referring to patch 1 and 2, which are the host side.  No page
> allocations.
> >>
> >> I'm good with 1 & 2,
> >>
> >> Christoph, you can add my
> >>
> >> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> >
> > We've missed the merge window now, so we can just wait for a proper
> > resend from Steve I think.
> >
> 
> There are still issue that I'm trying to help Steve with their debug so
> let's wait with the merge until we figure them out.

I would like review on my new nvmet-rdma changes to avoid > 0 order page
allocations though.  Perhaps I'll resend the series and add the RFC tag (or
WIP?) with verbiage saying don't merge yet.

  reply	other threads:[~2018-06-04 14:21 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 18:26 [PATCH v3 0/3] NVMF/RDMA 16K Inline Support Steve Wise
2018-05-29 18:25 ` [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support Steve Wise
2018-05-29 20:23   ` Ruhl, Michael J
2018-05-30 14:39     ` Steve Wise
2018-05-30 15:11       ` Steve Wise
2018-05-30 21:37         ` Sagi Grimberg
2018-05-31 17:02           ` hch
2018-05-31 17:17             ` Steve Wise
2018-05-31 17:25               ` hch
2018-06-01 13:08                 ` Steve Wise
2018-06-03 11:57                 ` Sagi Grimberg
2018-06-03 18:27                   ` Steve Wise
2018-06-04 12:01                     ` Sagi Grimberg
2018-06-04 12:11                       ` Christoph Hellwig
2018-06-04 12:17                         ` Steve Wise
2018-06-04 13:52                         ` Max Gurtovoy
2018-06-04 14:21                           ` Steve Wise [this message]
2018-06-04 14:29                             ` Max Gurtovoy
2018-06-04 14:31                               ` Steve Wise
2018-06-04 14:37                                 ` Max Gurtovoy
2018-06-04 14:45                                   ` Steve Wise
2018-05-31 17:00     ` hch
2018-05-29 18:25 ` [PATCH v3 2/3] nvme-rdma: support up to 4 segments of inline data Steve Wise
2018-05-30 21:42   ` Sagi Grimberg
2018-05-30 21:46     ` Steve Wise
2018-05-29 18:25 ` [PATCH v3 3/3] nvmet-rdma: support 16K " Steve Wise
2018-05-30 15:49   ` Christopher Lameter
2018-05-30 16:46     ` Steve Wise
2018-05-30 17:02       ` Christopher Lameter
2018-05-30 21:45     ` Sagi Grimberg
2018-05-30 21:52       ` Steve Wise
2018-05-30 22:13         ` Sagi Grimberg
2018-05-30 22:26           ` Steve Wise
2018-06-03  8:39   ` Max Gurtovoy
2018-06-03 18:25     ` Steve Wise
2018-06-04 13:58       ` Max Gurtovoy
2018-06-04 14:18         ` Steve Wise
2018-06-05  8:52           ` Max Gurtovoy
2018-06-05 14:28             ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='019101d3fc0f$4d32a4f0$e797eed0$@opengridcomputing.com' \
    --to=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).