From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH RFC v2 0/3] connect reject event helpers
Date: Mon, 24 Oct 2016 12:44:31 -0500 [thread overview]
Message-ID: <01aa01d22e1e$46b0bc90$d41235b0$@opengridcomputing.com> (raw)
In-Reply-To: <001701d22be6$4854b8b0$d8fe2a10$@opengridcomputing.com>
> >
> > > While reviewing:
> > >
> > >
> http://lists.infradead.org/pipermail/linux-nvme/2016-October/006681.html
> > >
> > > I decided to propose transport-agnostic helper functions to better
> > > handle connection reject event information. I've included a nvme_rdma
> > > patch to utilize the new helpers.
> > >
> > > Thoughts?
> >
> > Hey Steve,
> >
> > This looks nice and useful. Would be great if you can
> > also help other ULPs that use this (e.g. srp/srpt)
>
> can-do!
Actually, srp uses the ib_cm directly. Further it already has logic to do
various actions based on the IB_CM Reject status. It really doesn't need these
helpers. The only one would be ibcm_reject_msg(). Looking at the iser
initiator, it logs nothing on a reject event. And nfsrdma doesn't log any
details about the reject reason also.
I could add a dev_warn() or something for iser and nfsrdma.
Steve.
next prev parent reply other threads:[~2016-10-24 17:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 22:40 [PATCH RFC v2 0/3] connect reject event helpers Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 1/3] rdma_cm: add rdma_reject_msg() helper function Steve Wise
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 14:07 ` Steve Wise
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-20 22:40 ` [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() " Steve Wise
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 14:09 ` Steve Wise
2016-10-21 15:50 ` Parav Pandit
2016-10-21 21:45 ` Sagi Grimberg
2016-10-22 15:57 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects Steve Wise
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 21:48 ` Sagi Grimberg
2016-10-22 16:12 ` Steve Wise
[not found] ` <005701d22c7f$0c883ed0$2598bc70$@opengridcomputing.com>
2016-10-24 14:57 ` Steve Wise
2016-10-24 15:09 ` 'Christoph Hellwig'
2016-10-21 21:53 ` [PATCH RFC v2 0/3] connect reject event helpers Sagi Grimberg
2016-10-21 21:58 ` Steve Wise
[not found] ` <001701d22be6$4854b8b0$d8fe2a10$@opengridcomputing.com>
2016-10-24 17:44 ` Steve Wise [this message]
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:57 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01aa01d22e1e$46b0bc90$d41235b0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).