From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB2A9C25B75 for ; Mon, 3 Jun 2024 09:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4oOltfEcQUzwsT0hf8pJl6nN+Y3ghrxxX1hvOUIAO24=; b=HiHWVHQG41YTQE9sTod32yKCAP QDsMH7TJgjr/TVK3a3NIKk5KCpgjREkQl84xIIDPcxvZj9gloTalzchGjskRmnFJAuPaCtawSbnFS TxJTsHNxTcS+KmrB71eJlupAgogW20x+EsV5984IW3y5ToAPWs03ZBmYM3idtuK5hsP9lMr+NJnEQ 5XzGg372q4bQPIpqkV80iCgbYjBJ79LwViY0eZAIaXlKFW/xYATflPE+n+g2iIZBAS9mVZlZPVJGJ BhlPxEQy61n6KMobMQx3DNhljVY4/tXz2EjyOITGbrHVFd9koodZq9eNKzGlmv4qZq17g5tZyLmeL ageN+aUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE44c-0000000GEpA-1jGI; Mon, 03 Jun 2024 09:33:50 +0000 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE44R-0000000GEkk-4AyI for linux-nvme@lists.infradead.org; Mon, 03 Jun 2024 09:33:44 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0530B2001E; Mon, 3 Jun 2024 09:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717407218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oOltfEcQUzwsT0hf8pJl6nN+Y3ghrxxX1hvOUIAO24=; b=yhQlPd0MHvK2amD8/768y3cI5D+2sakKDNHLZCMlsVUhZlxTrzVuKSSdaoma1kF4Sdrorj HsyV3IAddUN8RqWE63fHe3Oa8La0Xbk4af7ju7n5+w/0UxYfYhxSSvLJQk0F2dQ0frpi2t L/6wnN5pjNmfL7B3AkDivxeQS0mx5+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717407218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oOltfEcQUzwsT0hf8pJl6nN+Y3ghrxxX1hvOUIAO24=; b=+RpgWfz0miPuVYsl6OfNOpxmkAuf7g294m39YR4+lwvmUZ0CQAaKleng4I2y4BJl6ofu2O AaotJnrh55atUdDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717407218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oOltfEcQUzwsT0hf8pJl6nN+Y3ghrxxX1hvOUIAO24=; b=yhQlPd0MHvK2amD8/768y3cI5D+2sakKDNHLZCMlsVUhZlxTrzVuKSSdaoma1kF4Sdrorj HsyV3IAddUN8RqWE63fHe3Oa8La0Xbk4af7ju7n5+w/0UxYfYhxSSvLJQk0F2dQ0frpi2t L/6wnN5pjNmfL7B3AkDivxeQS0mx5+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717407218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oOltfEcQUzwsT0hf8pJl6nN+Y3ghrxxX1hvOUIAO24=; b=+RpgWfz0miPuVYsl6OfNOpxmkAuf7g294m39YR4+lwvmUZ0CQAaKleng4I2y4BJl6ofu2O AaotJnrh55atUdDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E4735139CB; Mon, 3 Jun 2024 09:33:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IUdTN/GNXWZpBAAAD6G6ig (envelope-from ); Mon, 03 Jun 2024 09:33:37 +0000 Message-ID: <025702f4-5f3a-4fd1-897e-ac7b7d1ca8ec@suse.de> Date: Mon, 3 Jun 2024 11:33:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: blktests nvme 041,042 leak memory To: Maurizio Lombardi Cc: Maurizio Lombardi , Keith Busch , Sagi Grimberg , Yi Zhang , "open list:NVM EXPRESS DRIVER" , Shin'ichiro Kawasaki References: <93883147-490d-4065-a741-3e49288ea3af@grimberg.me> <8058afc6-8272-42fa-a024-e477a29148e1@suse.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[mail.ru]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[mail.ru,kernel.org,grimberg.me,redhat.com,lists.infradead.org,wdc.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[7]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_023340_214733_087DFAEB X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 6/3/24 10:52, Maurizio Lombardi wrote: > po 3. 6. 2024 v 10:37 odesílatel Hannes Reinecke napsal: >> >> On 5/31/24 16:37, Maurizio Lombardi wrote: >> Hmm. Don't really like it. >> We took great pains of moving then entire DH-CHAP code into its own >> file, and this patch reverts it and is causing the DH-CHAP code to be >> littered all over the place. > > This was just an example, I'm not asking to merge it. > > I just had to find a way to make it possible to call nvme_auth_stop() even > when nvme_auth_init() has never been called without crashing the kernel, > moving INIT_WORK was the easiest way. > Like this? diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c index a264b3ae078b..668cc4d891d7 100644 --- a/drivers/nvme/host/auth.c +++ b/drivers/nvme/host/auth.c @@ -983,7 +983,8 @@ EXPORT_SYMBOL_GPL(nvme_auth_init_ctrl); void nvme_auth_stop(struct nvme_ctrl *ctrl) { - cancel_work_sync(&ctrl->dhchap_auth_work); + if (ctrl->dhchap_ctxs) + cancel_work_sync(&ctrl->dhchap_auth_work); } EXPORT_SYMBOL_GPL(nvme_auth_stop); Cheers, Hannes