From: swise@opengridcomputing.com (Steve Wise)
Subject: nvme-fabrics: crash at nvme connect-all
Date: Fri, 10 Jun 2016 16:25:40 -0500 [thread overview]
Message-ID: <027d01d1c35e$a38b1bc0$eaa15340$@opengridcomputing.com> (raw)
In-Reply-To: <CAF1ivSa6k4tf5rtkBXdUPGqRxcYg1R_xP0HOOuKpV0kHXx0vkA@mail.gmail.com>
> -----Original Message-----
> From: Ming Lin [mailto:mlin at kernel.org]
> Sent: Friday, June 10, 2016 4:21 PM
> To: Steve Wise
> Cc: Jens Axboe; ming l; Sagi Grimberg; Marta Rybczynska; linux-
> nvme at lists.infradead.org; Christoph Hellwig; james p freyensee; keith busch;
> armenx baloyan
> Subject: Re: nvme-fabrics: crash at nvme connect-all
>
> On Fri, Jun 10, 2016 at 2:14 PM, Steve Wise <swise at opengridcomputing.com>
> wrote:
> >>
> >> Does Sagi's patch help?
> >>
> >> Author: Sagi Grimberg <sagi at grimberg.me>
> >> Date: Thu Jun 9 13:20:09 2016 -0700
> >>
> >> fabrics: Don't directly free opts->host
> >>
> >> It might be the default host, so we need to call
> >> nvmet_put_host (which is safe against NULL lucky for
> >> us).
> >>
> >> Reported-by: Alexander Nezhinsky <alexander.nezhinsky at excelero.com>
> >> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> >>
> >
> > Yes! Failures recover and subsequent connects work!
> >
> > Thanks for the help Ming! Sorry I'm finding already fixed problems. :(
>
> No problem :-)
> Can I have your Test-by tag?
>
I can't reply directly to Sagi's because it wasn't posted to linux-rdma apparently, and it must have been posted to linux-nvme before I joined. But for both:
Tested-by: Steve Wise <swise at opengridcomputing.com>
> Christoph,
>
> Could you apply these 2 patches?
>
> fabrics: Don't directly free opts->host
> nvme-rdma: correctly stop keep alive on error path
prev parent reply other threads:[~2016-06-10 21:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 9:18 nvme-fabrics: crash at nvme connect-all Marta Rybczynska
2016-06-09 9:29 ` Sagi Grimberg
2016-06-09 10:07 ` Marta Rybczynska
2016-06-09 11:09 ` Sagi Grimberg
2016-06-09 12:12 ` Marta Rybczynska
2016-06-09 12:30 ` Sagi Grimberg
2016-06-09 13:27 ` Steve Wise
2016-06-09 13:36 ` Steve Wise
2016-06-09 13:48 ` Sagi Grimberg
2016-06-09 14:09 ` Steve Wise
2016-06-09 14:22 ` Steve Wise
2016-06-09 14:29 ` Steve Wise
2016-06-09 15:04 ` Marta Rybczynska
2016-06-09 15:40 ` Steve Wise
2016-06-09 15:48 ` Steve Wise
2016-06-10 9:03 ` Marta Rybczynska
2016-06-10 13:40 ` Steve Wise
2016-06-10 13:42 ` Marta Rybczynska
2016-06-10 13:49 ` Steve Wise
2016-06-09 13:25 ` Christoph Hellwig
2016-06-09 13:24 ` Christoph Hellwig
2016-06-09 15:37 ` Marta Rybczynska
2016-06-09 20:25 ` Steve Wise
2016-06-09 20:35 ` Ming Lin
2016-06-09 21:06 ` Steve Wise
2016-06-09 22:26 ` Ming Lin
2016-06-09 22:40 ` Steve Wise
[not found] ` <055801d1c29f$e164c000$a42e4000$@opengridcomputing.com>
2016-06-10 15:11 ` Steve Wise
2016-06-10 16:22 ` Steve Wise
2016-06-10 18:43 ` Ming Lin
2016-06-10 19:17 ` Steve Wise
2016-06-10 20:00 ` Ming Lin
2016-06-10 20:15 ` Steve Wise
2016-06-10 20:18 ` Ming Lin
2016-06-10 21:14 ` Steve Wise
2016-06-10 21:20 ` Ming Lin
2016-06-10 21:25 ` Steve Wise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='027d01d1c35e$a38b1bc0$eaa15340$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox