From: Sagi Grimberg <sagi@grimberg.me>
To: Hou Pu <houpu.main@gmail.com>, elad.grupi@dell.com
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v5] nvmet-tcp: fix a segmentation fault during io parsing error
Date: Fri, 9 Apr 2021 10:52:49 -0700 [thread overview]
Message-ID: <02a00a10-bc15-ef58-406f-270116c4822b@grimberg.me> (raw)
In-Reply-To: <20210331091314.48925-1-houpu.main@gmail.com>
> From: Elad Grupi <elad.grupi@dell.com>
>
> In case there is an io that contains inline data and it goes to
> parsing error flow, command response will free command and iov
> before clearing the data on the socket buffer.
> This will delay the command response until receive flow is completed.
>
> Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")
> Signed-off-by: Elad Grupi <elad.grupi@dell.com>
> Signed-off-by: Hou Pu <houpu.main@gmail.com>
This looks fine to me:
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-09 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:24 [PATCH v4] nvmet-tcp: fix a segmentation fault during io parsing error elad.grupi
2021-03-31 7:48 ` Hou Pu
2021-03-31 8:28 ` Grupi, Elad
2021-03-31 9:07 ` Hou Pu
2021-03-31 13:06 ` Grupi, Elad
2021-03-31 9:13 ` [PATCH v5] " Hou Pu
2021-03-31 13:27 ` Grupi, Elad
2021-04-02 16:17 ` Christoph Hellwig
2021-04-05 19:01 ` Grupi, Elad
2021-04-05 19:03 ` Grupi, Elad
2021-04-06 3:28 ` Hou Pu
2021-04-09 17:52 ` Sagi Grimberg [this message]
2021-04-15 7:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a00a10-bc15-ef58-406f-270116c4822b@grimberg.me \
--to=sagi@grimberg.me \
--cc=elad.grupi@dell.com \
--cc=houpu.main@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox