From: Bradley Chapman <chapman6235@comcast.net>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: Problem with SPCC 256GB NVMe 1.3 drive - refcount_t: underflow; use-after-free.
Date: Mon, 25 Jan 2021 21:03:27 -0500 [thread overview]
Message-ID: <05db52bd-7484-56f1-510f-b1bd3808d385@comcast.net> (raw)
In-Reply-To: <6709E718-ABD5-4B69-B4E7-883C4E4CD178@wdc.com>
Good evening!
On 1/25/21 3:34 AM, Chaitanya Kulkarni wrote:
> I have pointed that out on friday already offline to reduce the mailing list noise.
>
>> On Jan 25, 2021, at 12:16 AM, Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>>
>> On Fri, Jan 22, 2021 at 07:54:26PM -0500, Bradley Chapman wrote:
>>> With the following patch applied to the NVMe tree, my system hard-locked and
>>> would not respond to Alt+SysRQ once I mounted the filesystem and attempted a
>>> directory listing of the root of the filesystem.
>>>
>>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>>> index 25456d02eddb..7ba5e8e92e19 100644
>>> --- a/drivers/nvme/host/pci.c
>>> +++ b/drivers/nvme/host/pci.c
>>> @@ -3228,6 +3228,8 @@ static const struct pci_device_id nvme_id_table[] = {
>>> .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>>> { PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
>>> .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>>> + { PCI_DEVICE(0x1d97, 0x2263), /* SPCC */
>>> + .driver_data = NVME_QUIRK_SINGLE_VECTOR },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
>>> .driver_data = NVME_QUIRK_SINGLE_VECTOR },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>>>
>>
>> Hello Bradley,
>>
>> Chaitanya asked you to test the NVME_QUIRK_DISABLE_WRITE_ZEROES quirk.
>> Your patch seems to instead use the NVME_QUIRK_SINGLE_VECTOR quirk.
>>
>> Did you try the NVME_QUIRK_DISABLE_WRITE_ZEROES quirk?
>>
>>
>> Kind regards,
>> Niklas
As Chaitanya pointed out, I did in fact re-test with the correct patch
and everything worked flawlessly. I have sent the corrected patches to
Chaitanya directly.
Brad
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-26 2:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 18:58 Problem with SPCC 256GB NVMe 1.3 drive - refcount_t: underflow; use-after-free Bradley Chapman
2021-01-18 4:36 ` Chaitanya Kulkarni
2021-01-18 18:33 ` Bradley Chapman
2021-01-20 3:08 ` Chaitanya Kulkarni
2021-01-21 2:33 ` Bradley Chapman
2021-01-21 12:45 ` Niklas Cassel
2021-01-22 2:32 ` Bradley Chapman
2021-01-22 2:54 ` Chaitanya Kulkarni
2021-01-22 2:54 ` Chaitanya Kulkarni
2021-01-22 2:54 ` Bradley Chapman
2021-01-22 2:57 ` Chaitanya Kulkarni
2021-01-22 3:16 ` Chaitanya Kulkarni
2021-01-23 0:54 ` Bradley Chapman
2021-01-25 8:16 ` Niklas Cassel
2021-01-25 8:34 ` Chaitanya Kulkarni
2021-01-26 2:03 ` Bradley Chapman [this message]
2021-01-26 2:04 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05db52bd-7484-56f1-510f-b1bd3808d385@comcast.net \
--to=chapman6235@comcast.net \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Niklas.Cassel@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox