From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/4] nvme: add support for mq_ops->queue_rqs()
Date: Mon, 6 Dec 2021 09:33:34 -0700 [thread overview]
Message-ID: <05f538ae-d0fc-c557-54a0-06a035ad06b2@kernel.dk> (raw)
In-Reply-To: <Ya2+buqfKSFHWVvu@infradead.org>
On 12/6/21 12:40 AM, Christoph Hellwig wrote:
> On Fri, Dec 03, 2021 at 02:45:44PM -0700, Jens Axboe wrote:
>> This enables the block layer to send us a full plug list of requests
>> that need submitting. The block layer guarantees that they all belong
>> to the same queue, but we do have to check the hardware queue mapping
>> for each request.
>>
>> If errors are encountered, leave them in the passed in list. Then the
>> block layer will handle them individually.
>>
>> This is good for about a 4% improvement in peak performance, taking us
>> from 9.6M to 10M IOPS/core.
>
> This looks pretty similar to my proposed cleanups (which is nice), but
> back then you mentioned the cleaner version was much slower. Do you
> know what brought the speed back in this version?
Yes, it has that folded in and tweaked on top. Current version seems
to be fine.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-06 16:33 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 21:45 [PATCHSET v2 0/4] Add support for list issue Jens Axboe
2021-12-03 21:45 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-12-04 10:43 ` Hannes Reinecke
2021-12-04 20:13 ` Jens Axboe
2021-12-05 9:07 ` Hannes Reinecke
2021-12-05 13:09 ` Jens Axboe
2021-12-03 21:45 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-04 10:44 ` Hannes Reinecke
2021-12-06 7:38 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe
2021-12-03 21:45 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-12-04 10:45 ` Hannes Reinecke
2021-12-03 21:45 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-04 10:47 ` Hannes Reinecke
2021-12-06 7:40 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 16:24 [PATCHSET v3 0/4] Add support for list issue Jens Axboe
2021-12-15 16:24 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-15 17:29 ` Keith Busch
2021-12-15 20:27 ` Jens Axboe
2021-12-16 9:08 ` Christoph Hellwig
2021-12-16 13:06 ` Max Gurtovoy
2021-12-16 15:48 ` Jens Axboe
2021-12-16 16:00 ` Max Gurtovoy
2021-12-16 16:05 ` Jens Axboe
2021-12-16 16:19 ` Max Gurtovoy
2021-12-16 16:25 ` Jens Axboe
2021-12-16 16:34 ` Max Gurtovoy
2021-12-16 16:36 ` Jens Axboe
2021-12-16 16:57 ` Max Gurtovoy
2021-12-16 17:16 ` Jens Axboe
2021-12-19 12:14 ` Max Gurtovoy
2021-12-19 14:48 ` Jens Axboe
2021-12-20 10:11 ` Max Gurtovoy
2021-12-20 14:19 ` Jens Axboe
2021-12-20 14:25 ` Jens Axboe
2021-12-20 15:29 ` Max Gurtovoy
2021-12-20 16:34 ` Jens Axboe
2021-12-20 18:48 ` Max Gurtovoy
2021-12-20 18:58 ` Jens Axboe
2021-12-21 10:20 ` Max Gurtovoy
2021-12-21 15:23 ` Jens Axboe
2021-12-21 15:29 ` Max Gurtovoy
2021-12-21 15:33 ` Jens Axboe
2021-12-21 16:08 ` Max Gurtovoy
2021-12-16 15:45 ` Jens Axboe
2021-12-16 16:15 ` Christoph Hellwig
2021-12-16 16:27 ` Jens Axboe
2021-12-16 16:30 ` Christoph Hellwig
2021-12-16 16:36 ` Jens Axboe
2021-12-16 13:02 ` Max Gurtovoy
2021-12-16 15:59 ` Jens Axboe
2021-12-16 16:06 ` Max Gurtovoy
2021-12-16 16:09 ` Jens Axboe
2021-12-16 16:05 [PATCHSET v4 0/4] Add support for list issue Jens Axboe
2021-12-16 16:05 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-16 16:38 [PATCHSET v5 0/4] Add support for list issue Jens Axboe
2021-12-16 16:39 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-16 17:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f538ae-d0fc-c557-54a0-06a035ad06b2@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox