linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v2 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
Date: Tue, 16 Aug 2016 11:56:08 +0300	[thread overview]
Message-ID: <06a25d8a-1215-b117-bfee-aa28c071956d@grimberg.me> (raw)
In-Reply-To: <1471279659-25951-4-git-send-email-james_p_freyensee@linux.intel.com>


> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index e06d504..68b7b04 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1004,11 +1004,11 @@ nvmet_rdma_parse_cm_connect_req(struct rdma_conn_param *conn,
>  	queue->host_qid = le16_to_cpu(req->qid);
>
>  	/*
> -	 * req->hsqsize corresponds to our recv queue size
> -	 * req->hrqsize corresponds to our send queue size
> +	 * req->hsqsize corresponds to our recv queue size plus 1
> +	 * req->hrqsize corresponds to our send queue size plus 1
>  	 */
> -	queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> -	queue->send_queue_size = le16_to_cpu(req->hrqsize);
> +	queue->recv_queue_size = le16_to_cpu(req->hsqsize) + 1;
> +	queue->send_queue_size = le16_to_cpu(req->hrqsize) + 1;
>
>  	if (!queue->host_qid && queue->recv_queue_size > NVMF_AQ_DEPTH)
>  		return NVME_RDMA_CM_INVALID_HSQSIZE;
>

In order to keep bisectability this patch should come first. Otherwise
in prior patches the host sends smaller queue then it actually uses.

So this patch should come first, and only then we make the host
send sqsize-1.

  reply	other threads:[~2016-08-16  8:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 16:47 [PATCH v2 0/5] sqsize fixes Jay Freyensee
2016-08-15 16:47 ` [PATCH v2 1/5] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-16  8:59   ` Sagi Grimberg
2016-08-16 16:19     ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 2/5] nvme-rdma: fix sqsize/hsqsize " Jay Freyensee
2016-08-16  8:57   ` Sagi Grimberg
2016-08-16 16:20     ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-16  8:56   ` Sagi Grimberg [this message]
2016-08-16 16:22     ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 4/5] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee
2016-08-16  8:59   ` Sagi Grimberg
2016-08-16 16:22     ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 5/5] nvme-rdma: adjust hrqsize to plus 1 Jay Freyensee
2016-08-16  9:05   ` Sagi Grimberg
2016-08-16 16:34     ` J Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06a25d8a-1215-b117-bfee-aa28c071956d@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).