From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH v3 2/5] nvme_fc: change ctlr state assignments during reset/reconnect
Date: Fri, 20 Oct 2017 08:00:08 +0200 [thread overview]
Message-ID: <06d12d08-990f-26fa-fe73-127dbe4a7f4e@suse.de> (raw)
In-Reply-To: <20171017233248.6769-3-jsmart2021@gmail.com>
On 10/18/2017 01:32 AM, James Smart wrote:
> Clean up some of the controller state checks and add the
> RESETTING->RECONNECTING state transition.
>
> Specifically:
> - the movement of the RESETTING state change and schedule of
> reset_work to core doesn't work wiht nvme_fc_error_recovery
> setting state to RECONNECTING before attempting to reset.
> Remove the state change as the reset request does it.
> - In the rare cases where an error occurs right as we're
> transitioning to LIVE, defer the controller start actions.
> - In error handling on teardown of associations while
> performing initial controller creation - avoid quiesce
> calls on the admin_q. They are unneeded.
> - Add the RESETTING->RECONNECTING transition in the reset
> handler.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> ---
> v3: no change. incorporated Reviewed-by's
> ---
> drivers/nvme/host/fc.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare at suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2017-10-20 6:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 23:32 [PATCH v3 0/5] nvme_fc: add dev_loss_tmo support James Smart
2017-10-17 23:32 ` [PATCH v3 1/5] nvme core: allow controller RESETTING to RECONNECTING transition James Smart
2017-10-18 8:26 ` Johannes Thumshirn
2017-10-20 5:58 ` Hannes Reinecke
2017-10-17 23:32 ` [PATCH v3 2/5] nvme_fc: change ctlr state assignments during reset/reconnect James Smart
2017-10-18 8:27 ` Johannes Thumshirn
2017-10-20 6:00 ` Hannes Reinecke [this message]
2017-10-17 23:32 ` [PATCH v3 3/5] nvme_fc: add a dev_loss_tmo field to the remoteport James Smart
2017-10-18 8:28 ` Johannes Thumshirn
2017-10-20 6:04 ` Hannes Reinecke
2017-10-20 14:50 ` James Smart
2017-10-17 23:32 ` [PATCH v3 4/5] nvme_fc: check connectivity before initiating reconnects James Smart
2017-10-18 8:29 ` Johannes Thumshirn
2017-10-20 6:05 ` Hannes Reinecke
2017-10-17 23:32 ` [PATCH v3 5/5] nvme_fc: add dev_loss_tmo timeout and remoteport resume support James Smart
2017-10-19 15:46 ` Trapp, Darren
2017-10-19 18:04 ` James Smart
2017-10-19 19:49 ` Trapp, Darren
2017-10-20 6:27 ` Hannes Reinecke
2017-10-20 18:53 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06d12d08-990f-26fa-fe73-127dbe4a7f4e@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).