From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: fix multipath batched completion accounting
Date: Wed, 22 May 2024 00:55:41 +0000 [thread overview]
Message-ID: <07104aea-e149-48b0-860c-cfb871a7db41@nvidia.com> (raw)
In-Reply-To: <20240521170537.2029233-1-kbusch@meta.com>
On 5/21/24 10:05, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Batched completions were missing the io stats accounting and bio trace
> events. Move the common code to a helper and call it from the batched
> and non-batched functions.
>
> Fixes: d4d957b53d91ee ("nvme-multipath: support io stats on the mpath device")
> Signed-off-by: Keith Busch <kbusch@kernel.org>
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-05-22 0:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 17:05 [PATCH] nvme: fix multipath batched completion accounting Keith Busch
2024-05-21 19:37 ` Christoph Hellwig
2024-05-21 20:11 ` Sagi Grimberg
2024-05-22 0:55 ` Chaitanya Kulkarni [this message]
2024-05-23 9:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07104aea-e149-48b0-860c-cfb871a7db41@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox