From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Yi Zhang <yi.zhang@redhat.com>,
linux-nvme@lists.infradead.org,
Maurizio Lombardi <mlombard@redhat.com>
Subject: Re: [PATCH] nvmet-tcp: do not try to cancel uninitialized tls_handshake_tmo_work
Date: Thu, 19 Oct 2023 15:07:53 +0200 [thread overview]
Message-ID: <09ea6825-e73e-44a7-8540-ea92907eb858@suse.de> (raw)
In-Reply-To: <61a4991d-1ad3-4c7e-8629-ac3100a0f745@kernel.dk>
On 10/19/23 15:01, Jens Axboe wrote:
> On 10/19/23 6:53 AM, Hannes Reinecke wrote:
>> The TLS handshake timeout workqueue is only initialized if TLS
>> is configured, so we shouldn't try to de-initialize it
>> unconditionally.
>
> What about the one in nvmet_tcp_tls_handshake_done()?
>
That already is encapsulated by the config variable, so nothing to be
done here.
> Please include a fixes line.
>
Oh, sure.
Cheers,
Hannes
prev parent reply other threads:[~2023-10-19 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 12:53 [PATCH] nvmet-tcp: do not try to cancel uninitialized tls_handshake_tmo_work Hannes Reinecke
2023-10-19 13:01 ` Jens Axboe
2023-10-19 13:07 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ea6825-e73e-44a7-8540-ea92907eb858@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox