From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD845C432C0 for ; Mon, 2 Dec 2019 23:36:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8035820656 for ; Mon, 2 Dec 2019 23:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OpFPEB2h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="RHvWjoaZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8035820656 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHoPVfxfBHVxEGhRIW8OHYmgf4gRPbYFwEIFYEx0L54=; b=OpFPEB2hP7tLkJ scZhdY1GbsuIwLZivQfpxr/vbE4bWc6ipCKNN6FDK3jyZp/omgz762718rNSyffs7fKFRdQWyS9wc YodAvnpFsVYjEGyrQLBPRTnJLSuYgXKDUC21IrwK5hTbVWKwrb4mz8s3EtEnoFek7hSxuV/BNXUk4 LFIZaGBqXRn2LSFQkUmgPituVstqYYovqQ0Ou+pbh9eQp2gLdLyC1RbU9Fivlf6j2HiytSUU0G2zD 983WdF5Cnvx18ToytPXNZjzmYlEcptnhncOJPgDnvJYn0hPDCI/E4UPhuLnYSg5uWANQJbkW46v4s Q2ky3UAB3eUUFw8HFq9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibvER-0005qf-Hd; Mon, 02 Dec 2019 23:35:55 +0000 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibvEP-0005qG-Au for linux-nvme@lists.infradead.org; Mon, 02 Dec 2019 23:35:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1575329754; x=1606865754; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lJVMMBtj13i5L3b9emIdKlF5B2W8hwoF+8H+kt2s0uQ=; b=RHvWjoaZbyhA9iCbXrHZYUYhhlWBW72v3bTS/FPeXcCbZTypf+TpxVHO YI2+YY2ayBULdXSJGSOkuszVdKf1jYTVH2XXNbdII5s56v2iLpFNEeBH7 95xNGfmcGlzgyCTu2VzGTJIjHzfwTxxg/kSL/RmdsmM2xoZtrrBLcZi1T k=; IronPort-SDR: 6GhwZJNcbQOCCmZ67p2dIO5FsBLaEWtvXLI+SApjgZPZQ0NAkdedMm25Wz3mUqIN1EHkp7M7lW JKIZ0etznqPQ== X-IronPort-AV: E=Sophos;i="5.69,270,1571702400"; d="scan'208";a="6783055" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 02 Dec 2019 23:35:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2b-4e24fd92.us-west-2.amazon.com (Postfix) with ESMTPS id 33ADAA082C; Mon, 2 Dec 2019 23:35:48 +0000 (UTC) Received: from EX13D11UWB002.ant.amazon.com (10.43.161.20) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Dec 2019 23:35:48 +0000 Received: from EX13D01UWB002.ant.amazon.com (10.43.161.136) by EX13D11UWB002.ant.amazon.com (10.43.161.20) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Dec 2019 23:35:47 +0000 Received: from EX13D01UWB002.ant.amazon.com ([10.43.161.136]) by EX13d01UWB002.ant.amazon.com ([10.43.161.136]) with mapi id 15.00.1367.000; Mon, 2 Dec 2019 23:35:47 +0000 From: "Singh, Balbir" To: "hch@lst.de" Subject: Re: [RFC][PATCH] nvme/core: Notify udev about capacity change Thread-Topic: [RFC][PATCH] nvme/core: Notify udev about capacity change Thread-Index: AQHVpkvgVfUA8zeU+0yg5tgW9Ce9QKeh0FaAgAW1gYA= Date: Mon, 2 Dec 2019 23:35:47 +0000 Message-ID: <0a5fc287a4ac392b9b192402e6786e7129b9d5f2.camel@amazon.com> References: <20191129002746.6622-1-sblbir@amazon.com> <20191129082449.GA9953@lst.de> In-Reply-To: <20191129082449.GA9953@lst.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.160.100] Content-ID: <66F36C053D1CD948A65829DA501F1B67@amazon.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_153553_507165_E3AD96D8 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kbusch@kernel.org" , "axboe@fb.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "Sangaraju, Someswarudu" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, 2019-11-29 at 09:24 +0100, Christoph Hellwig wrote: > I don't think this makes sense, and they way it has been done in > virtio_blk and xen-blkfront is an utter hack. Please first add a > properly documented block helper, and then make sure it doesn't send the > even for the first call that moves from a 0 capacity. SCSI also will > need updating to use the helper. Makes sense, I am wondering if I should refactor set_capacity to __set_capacity and have set_capacity do notifcations for oldsize vs newsize where oldsize is not 0 Balbir Singh. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme