From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A00C7C5478C for ; Wed, 28 Feb 2024 02:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qoFpD+XCA+BC2zRmUiV4QLlBoYkqPi7M1IagIeCBRfs=; b=q/fxnGraat+wgRVHzUrt/nXzGo LQAa7zcv0LVH9cXLNNLgC51pw/MZ2APJNwPSxIEgEU+1mk4DOIwQEpr1ZcteeGDnU1LnecuUNiti3 DOTPCUDUOjyeYj1brA8n37IFdnHOHWv2RkhBkZ4ASMKcPbMJ9kO3TGd/rnUpSzNTu/NElPj0vdAtV n/agces921optTRGgpwYB02zJRvpaMECmCzrWhnMaLinmSNBEcvn1IGr5cEZApH71logZq7MuvPL3 ebT2+BVFW2b56hs7a/GVa3LjTzMwrc0bzg6H3uyVzDThCtG/V84wVrwKmXMKXYfHORH4tSfiA6V+2 uw/ztYAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf9aE-00000007hAD-096C; Wed, 28 Feb 2024 02:22:10 +0000 Received: from out30-113.freemail.mail.aliyun.com ([115.124.30.113]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf9aA-00000007h8r-3EFv for linux-nvme@lists.infradead.org; Wed, 28 Feb 2024 02:22:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1709086921; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=qoFpD+XCA+BC2zRmUiV4QLlBoYkqPi7M1IagIeCBRfs=; b=Rlfqfk5ik6ks85EcQItHAEgwInUn3TUxydwx6kO0foVrGfhNCOfXAFwybpJjLcBB2PDxIAF4W/pxAxPNNHRRPsIp0YV+/nyHbBxooD+lRjfEIWfqbX46PSgsuWVIkAwG+I1h3Pg7+1X6keH0IxLVWCSeqBok8zJAQGImM2N8dJ0= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=kanie@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0W1O7xbH_1709086918; Received: from 30.178.83.72(mailfrom:kanie@linux.alibaba.com fp:SMTPD_---0W1O7xbH_1709086918) by smtp.aliyun-inc.com; Wed, 28 Feb 2024 10:21:59 +0800 Message-ID: <0c74a2c2-c9d9-4b0c-9deb-bdc3caf72005@linux.alibaba.com> Date: Wed, 28 Feb 2024 10:21:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/1] nvmet: support reservation feature Content-Language: en-GB To: Sagi Grimberg , hch@lst.de, kch@nvidia.com Cc: linux-nvme@lists.infradead.org References: <20240201023207.112007-1-kanie@linux.alibaba.com> <20240201023207.112007-2-kanie@linux.alibaba.com> From: Guixin Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_182207_486454_673F4123 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org 在 2024/2/28 08:40, Sagi Grimberg 写道: > Hey Guixin, > > On 01/02/2024 4:32, Guixin Liu wrote: >> This patch implements the reservation feature, includes: >> 1. reservation register(register, unregister and replace). >> 2. reservation acquire(acquire, preempt, preempt and abort). > > > Overall patchset looks in decent shape to me now. > > I do have one more question though. My thanks for your patient review. > > You say that this patchset implements preempt and abort, however I > don't see how this is actually implemented or even how can it be > implemented at all at this point. Yes, the nvme target does not do any useful workto abort command, the comment of nvmet_execute_abort() says that "we are not required to do any useful work, and we couldn't really do a useful abort", so I don't know what to do about preempt and abort, and the NVMe spec says that the abort is best effor. My statement here may be a little inaccurate. Best Regards, Guixin Liu