Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de
Cc: oren@nvidia.com, israelr@nvidia.com, kbusch@kernel.org
Subject: Re: [PATCH 1/1] nvme-rdma: fix typo in comment
Date: Thu, 30 Mar 2023 12:30:18 +0300	[thread overview]
Message-ID: <0d52d8ac-a64d-402b-ffab-fe278f11a280@nvidia.com> (raw)
In-Reply-To: <20220525145940.575-1-mgurtovoy@nvidia.com>

Hi Christoph/Sagi,
I've noticed that the bellow patch wasn't merged.
Can we take it for next cycle please ?

On 25/05/2022 17:59, Max Gurtovoy wrote:
> There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.
> 
> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>   drivers/nvme/host/rdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index d9f19d901313..12c7ea61ed0c 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -509,7 +509,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
>   	}
>   	ibdev = queue->device->dev;
>   
> -	/* +1 for ib_stop_cq */
> +	/* +1 for ib_drain_qp */
>   	queue->cq_size = cq_factor * queue->queue_size + 1;
>   
>   	ret = nvme_rdma_create_cq(ibdev, queue);


  reply	other threads:[~2023-03-30  9:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 14:59 [PATCH 1/1] nvme-rdma: fix typo in comment Max Gurtovoy
2023-03-30  9:30 ` Max Gurtovoy [this message]
2023-03-30 16:18 ` Sagi Grimberg
  -- strict thread matches above, loose matches on Subject: below --
2023-04-19 23:17 Max Gurtovoy
2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 17:14 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d52d8ac-a64d-402b-ffab-fe278f11a280@nvidia.com \
    --to=mgurtovoy@nvidia.com \
    --cc=hch@lst.de \
    --cc=israelr@nvidia.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=oren@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox