From: Hannes Reinecke <hare@suse.de>
To: Muneendra <muneendra.kumar@broadcom.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: pbonzini@redhat.com, jsmart2021@gmail.com, mkumar@redhat.com,
emilne@redhat.com,
Gaurav Srivastava <gaurav.srivastava@broadcom.com>
Subject: Re: [PATCH v4 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread
Date: Mon, 16 Nov 2020 09:12:24 +0100 [thread overview]
Message-ID: <0ded4be6-f4e1-8d13-5b1a-930045247237@suse.de> (raw)
In-Reply-To: <1604895845-2587-18-git-send-email-muneendra.kumar@broadcom.com>
On 11/9/20 5:24 AM, Muneendra wrote:
> From: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
>
> This patch add the periodic check for issuing of qfpa command and vmid
> timeout in the worker thread. The inactivity timeout check is added via
> the timer function.
>
> Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
>
> ---
> v4:
> No change
>
> v3:
> No change
>
> v2:
> Ported the patch on top of 5.10/scsi-queue
> ---
> drivers/scsi/lpfc/lpfc_hbadisc.c | 42 ++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> index b20013866942..38df3c4341f9 100644
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
> @@ -433,6 +433,32 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp)
> return fcf_inuse;
> }
>
> +void lpfc_check_vmid_qfpa_issue(struct lpfc_hba *phba)
> +{
> + struct lpfc_vport *vport;
> + struct lpfc_vport **vports;
> + int i, ret;
> +
> + vports = lpfc_create_vport_work_array(phba);
> + if (!vports)
> + return;
> +
> + for (i = 0; i <= phba->max_vports; i++) {
> + if ((!vports[i]) && (i == 0))
> + vport = phba->pport;
> + else
> + vport = vports[i];
> + if (!vport)
> + break;
> +
> + if (vport->vmid_flag & LPFC_VMID_ISSUE_QFPA) {
> + ret = lpfc_issue_els_qfpa(vport);
> + vport->vmid_flag &= ~LPFC_VMID_ISSUE_QFPA;
> + }
> + }
> + lpfc_destroy_vport_work_array(phba, vports);
> +}
> +
> /**
> * lpfc_sli4_post_dev_loss_tmo_handler - SLI4 post devloss timeout handler
> * @phba: Pointer to hba context object.
> @@ -744,6 +770,22 @@ lpfc_work_done(struct lpfc_hba *phba)
> if (ha_copy & HA_LATT)
> lpfc_handle_latt(phba);
>
> + /* Handle VMID Events */
> + if (lpfc_is_vmid_enabled(phba)) {
> + if (phba->pport->work_port_events &
> + WORKER_CHECK_VMID_ISSUE_QFPA) {
> + lpfc_check_vmid_qfpa_issue(phba);
> + phba->pport->work_port_events &=
> + ~WORKER_CHECK_VMID_ISSUE_QFPA;
> + }
> + if (phba->pport->work_port_events &
> + WORKER_CHECK_INACTIVE_VMID) {
> + lpfc_check_inactive_vmid(phba);
> + phba->pport->work_port_events &=
> + ~WORKER_CHECK_INACTIVE_VMID;
> + }
> + }
> +
> /* Process SLI4 events */
> if (phba->pci_dev_grp == LPFC_PCI_DEV_OC) {
> if (phba->hba_flag & HBA_RRQ_ACTIVE)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-16 8:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 4:23 [PATCH v4 00/19] blkcg:Support to track FC storage blk io traffic Muneendra
2020-11-09 4:23 ` [PATCH v4 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-11-16 7:25 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 02/19] blkcg: Added a app identifier support for blkcg Muneendra
2020-11-09 13:55 ` Tejun Heo
2020-11-16 7:31 ` Hannes Reinecke
2020-11-18 9:39 ` Muneendra Kumar M
2020-11-09 4:23 ` [PATCH v4 03/19] nvme: Added a newsysfs attribute appid_store Muneendra
2020-11-16 7:39 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-11-16 7:41 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-11-16 7:44 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-11-16 7:49 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 07/19] lpfc: vmid: Forward declarations for APIs Muneendra
2020-11-16 7:50 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-11-16 7:52 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 09/19] lpfc: vmid: VMID params initialization Muneendra
2020-11-16 7:53 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 10/19] lpfc: vmid: vmid resource allocation Muneendra
2020-11-16 7:56 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 11/19] lpfc: vmid: cleanup vmid resources Muneendra
2020-11-16 7:56 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-11-16 8:03 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 13/19] lpfc: vmid: Functions to manage vmids Muneendra
2020-11-16 8:06 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 14/19] lpfc: vmid: Implements CT commands for appid Muneendra
2020-11-16 8:08 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-11-16 8:10 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-11-16 8:11 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-11-16 8:12 ` Hannes Reinecke [this message]
2020-11-09 4:24 ` [PATCH v4 18/19] lpfc: vmid: Introducing vmid in io path Muneendra
2020-11-16 8:13 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2020-11-16 8:15 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ded4be6-f4e1-8d13-5b1a-930045247237@suse.de \
--to=hare@suse.de \
--cc=emilne@redhat.com \
--cc=gaurav.srivastava@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=pbonzini@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox