From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "osandov@fb.com" <osandov@fb.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes
Date: Wed, 12 Jan 2022 17:55:15 +0000 [thread overview]
Message-ID: <0dfab539-c85b-68da-0a2e-3765d7d3903e@nvidia.com> (raw)
In-Reply-To: <dabc21d2-6431-67e0-8ce5-62c74c76bc99@grimberg.me>
Sagi,
On 1/12/22 12:38 AM, Sagi Grimberg wrote:
> External email: Use caution opening links or attachments
>
>
> What is preventing this to break again?
>
> Can we modify the tests to not rely on a consistent
> output here. Perhaps just search/match the expected nvm subsystems
> in the log page?
Do we expect to change the output of the log page again ?
It is important to match the disc subsysnqn i.e.
"nqn.2014-08.org.nvmexpress.discovery" and gencounter,
only matching the nvm subsystems not going to get us good
coverage.
-ck
next prev parent reply other threads:[~2022-01-12 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 6:06 [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 1/3] tests/nvme/002: adjust to new nvme disc page output Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 2/3] tests/nvme/016: " Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 3/3] tests/nvme/017: " Chaitanya Kulkarni
2022-01-12 8:38 ` [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes Sagi Grimberg
2022-01-12 17:55 ` Chaitanya Kulkarni [this message]
2022-01-12 22:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dfab539-c85b-68da-0a2e-3765d7d3903e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox