linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mrybczyn@kalray.eu (Marta Rybczynska)
Subject: [PATCH RFC] nvme-rdma: support devices with queue size < 32
Date: Thu, 30 Mar 2017 16:23:28 +0200 (CEST)	[thread overview]
Message-ID: <1121115847.336382032.1490883808617.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <2ba93b5b-ad36-5533-36e2-9db2e3198c19@grimberg.me>

>>> You say above "we post *up to* 2 work requests", unless you wish to
>>> change that to "we always post at least 2 work requests per queue
>>> entry", Jason is right, your frequency of signaling needs to be X/2
>>> regardless of your CQ size, you need the signaling to control the queue
>>> depth tracking.
>>
>> If you would like to spread things out farther between signaling, then
>> you can modify your send routine to only increment the send counter for
>> actual send requests, ignoring registration WQEs and invalidate WQES,
>> and then signal every X/2 sends.
> 
> Yea, you're right, and not only I got it wrong, I even contradicted my
> own suggestion that was exactly what you and Jason suggested (where is
> the nearest rat-hole...)
> 
> So I suggested to signal every X/2 and Marta reported SQ overflows for
> high queue-dpeth. Marta, at what queue-depth have you seen this?

The remote side had queue depth of 16 or 32 and that's the WQ on the
initiator side that overflows (mlx5_wq_overflow). We're testing with
signalling X/2 and it seems to work.

Marta

  parent reply	other threads:[~2017-03-30 14:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  9:04 [PATCH RFC] nvme-rdma: support devices with queue size < 32 Marta Rybczynska
2017-03-23  9:24 ` Marta Rybczynska
2017-03-23 14:00 ` Christoph Hellwig
2017-03-23 14:36   ` Marta Rybczynska
2017-03-28 11:09     ` Sagi Grimberg
2017-03-28 11:20       ` Marta Rybczynska
2017-03-28 11:30         ` Sagi Grimberg
2017-03-29  9:36           ` Marta Rybczynska
2017-03-29 13:29           ` Jason Gunthorpe
2017-03-29 15:47             ` Sagi Grimberg
2017-03-29 16:27               ` Jason Gunthorpe
2017-03-29 16:39                 ` Sagi Grimberg
2017-03-29 16:44                   ` Doug Ledford
2017-03-29 16:47                     ` Doug Ledford
2017-03-29 16:59                       ` Sagi Grimberg
2017-03-29 22:19                         ` Jason Gunthorpe
2017-03-30 14:23                         ` Marta Rybczynska [this message]
2017-04-06 12:29                           ` Marta Rybczynska
2017-04-06 13:02                             ` Leon Romanovsky
2017-04-07 13:31                               ` Marta Rybczynska
2017-04-09 12:31                                 ` Sagi Grimberg
2017-04-10 11:29                                   ` Marta Rybczynska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1121115847.336382032.1490883808617.JavaMail.zimbra@kalray.eu \
    --to=mrybczyn@kalray.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).