From: Yi Zhang <yi.zhang@redhat.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org
Subject: Re: NVMeoF RDMA IB: I/O timeout and NULL pointer observed during rescan_controller/reset_controller with fio background
Date: Tue, 24 Sep 2019 00:52:52 -0400 (EDT) [thread overview]
Message-ID: <116222781.3022437.1569300772965.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <0a8fffe2-f607-26ac-43f5-86182b1c782e@mellanox.com>
Hi Max/Sagi
Sorry for the late response, will update it today.
Best Regards,
Yi Zhang
----- Original Message -----
From: "Max Gurtovoy" <maxg@mellanox.com>
To: "Sagi Grimberg" <sagi@grimberg.me>, "Yi Zhang" <yi.zhang@redhat.com>, linux-nvme@lists.infradead.org
Sent: Monday, September 23, 2019 11:25:31 PM
Subject: Re: NVMeoF RDMA IB: I/O timeout and NULL pointer observed during rescan_controller/reset_controller with fio background
Any update Yi ?
we must fix this issue..
On 9/20/2019 7:58 PM, Sagi Grimberg wrote:
> Thanks for reporting Yi,
>
> Does this fix your issue?
>
> --
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index dfa07bb9dfeb..981da9ce3cfc 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -614,7 +614,8 @@ static int nvme_rdma_start_queue(struct
> nvme_rdma_ctrl *ctrl, int idx)
> if (!ret) {
> set_bit(NVME_RDMA_Q_LIVE, &queue->flags);
> } else {
> - __nvme_rdma_stop_queue(queue);
> + if (test_bit(NVME_RDMA_Q_ALLOCATED, &queue->flags))
> + __nvme_rdma_stop_queue(queue);
> dev_info(ctrl->ctrl.device,
> "failed to connect queue: %d ret=%d\n", idx,
> ret);
> }
> --
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-24 4:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1823328454.445263.1568796846850.JavaMail.zimbra@redhat.com>
2019-09-18 9:13 ` NVMeoF RDMA IB: I/O timeout and NULL pointer observed during rescan_controller/reset_controller with fio background Yi Zhang
2019-09-18 14:21 ` Max Gurtovoy
2019-09-20 3:37 ` Yi Zhang
2019-09-20 16:58 ` Sagi Grimberg
2019-09-23 15:25 ` Max Gurtovoy
2019-09-24 4:52 ` Yi Zhang [this message]
2019-09-27 8:17 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116222781.3022437.1569300772965.JavaMail.zimbra@redhat.com \
--to=yi.zhang@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox