From: alan.adamson@oracle.com
To: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Cc: Keith Busch <kbusch@kernel.org>,
Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
Subject: Re: [PATCH] nvme: move passthrough logging attribute to head
Date: Wed, 7 Feb 2024 10:28:19 -0800 [thread overview]
Message-ID: <11e49673-d25b-4677-925d-ca6f8ca39fd4@oracle.com> (raw)
In-Reply-To: <20240206175040.553999-1-kbusch@meta.com>
On 2/6/24 9:50 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The namespace does not have attributes, but the head does. Move the new
> attribute to that structure instead of dereferncing the wrong type.
>
> And while we're here, fix the reverse-tree coding style.
>
> Fixes: 9f079dda14339e ("nvme: allow passthru cmd error logging")
> Reported-by: Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
> Cc: Alan Adamson <alan.adamson@oracle.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good.
Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
I tested it with blktest tests I'm putting together for passthrough errors.
Alan
next prev parent reply other threads:[~2024-02-07 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:50 [PATCH] nvme: move passthrough logging attribute to head Keith Busch
2024-02-07 4:02 ` Chaitanya Kulkarni
2024-02-07 5:54 ` Keith Busch
2024-02-07 8:43 ` Tasmiya Nalatwad
2024-02-07 18:28 ` alan.adamson [this message]
2024-02-07 18:40 ` Keith Busch
2024-02-08 8:00 ` Tasmiya Nalatwad
2024-02-12 6:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e49673-d25b-4677-925d-ca6f8ca39fd4@oracle.com \
--to=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tasmiya@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox