Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"hch@lst.de" <hch@lst.de>,
	"jsmart2021@gmail.com" <jsmart2021@gmail.com>
Subject: Re: [PATCH 2/2] nvme-fc: check sgl supported by target
Date: Wed, 31 Mar 2021 12:28:14 +0300	[thread overview]
Message-ID: <11f750f1-c805-7d6b-b8cf-d713f918f61e@nvidia.com> (raw)
In-Reply-To: <BYAPR04MB496516848BF2ECE9FAEB32D7867D9@BYAPR04MB4965.namprd04.prod.outlook.com>


On 3/31/2021 2:42 AM, Chaitanya Kulkarni wrote:
> On 3/30/21 16:01, Max Gurtovoy wrote:
>> SGLs support is mandatory for NVMe/tcp, make sure that the target is
>> aligned to the specification.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> s/"NVMe/tcp"/"NVMe-FC"/ ? if so that can be done by at the time of
> applying the patch, if not just ignore this comment.

Good catch. Yes, this should be updated.

Thanks.

>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
>
>

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-03-31  9:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 23:01 [PATCH 1/2] nvme-tcp: check sgl supported by target Max Gurtovoy
2021-03-30 23:01 ` [PATCH 2/2] nvme-fc: " Max Gurtovoy
2021-03-30 23:42   ` Chaitanya Kulkarni
2021-03-31  9:28     ` Max Gurtovoy [this message]
2021-03-30 23:39 ` [PATCH 1/2] nvme-tcp: " Chaitanya Kulkarni
2021-03-31  0:29 ` Keith Busch
2021-03-31  1:12   ` Chaitanya Kulkarni
2021-03-31  9:37     ` Max Gurtovoy
2021-04-02 16:49 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11f750f1-c805-7d6b-b8cf-d713f918f61e@nvidia.com \
    --to=mgurtovoy@nvidia.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=jsmart2021@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox