Re: [RFC COMPILE ONLY PATCH 0/2] nvme-core: dhchap_secret code cleanup

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

Hannes,

On 4/27/23 01:02, Chaitanya Kulkarni wrote:
> Hi,
>
> Marking it compile only RFC since blktests are failing on current
> nvme-6.4 so I was not able to complete the testing.
>
> Bunch of code is repeated all over when defining nvme_ctrl_dhchap_secret
> and nvme_ctrl_dhchap_ctrl_secret. Factor out a common function for
> nvme_ctrl_secret_dhchap_store() and nvme_ctrl_secret_dhchap_ctrl_store()
> into common function nvme_dhchap_secret_store_common().
>
> Add a macro to define device attr in order to remove code duplication
> for above mentioned attributes.
>
> No functional changes in this patch-series.
>
> -ck
>
> Chaitanya Kulkarni (2):
>    nvme-core: factor out common code into helper
>    nvme-core: use macro defination to define dev attr
>
>   drivers/nvme/host/core.c | 128 ++++++++++++++-------------------------
>   1 file changed, 44 insertions(+), 84 deletions(-)
>

it will be great if you can provide some feedback, it removes a lot of
duplicated code and potential bugs that are also duplicated,
so we can add this to next PR ...

-ck