linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vishal.l.verma@intel.com (Vishal Verma)
Subject: [PATCH] NVMe: Fix a build error for u64 division
Date: Thu, 28 Mar 2013 12:42:50 -0600	[thread overview]
Message-ID: <1364496170-27921-1-git-send-email-vishal.l.verma@intel.com> (raw)

A u64 division was producing a linker error with CONFIG_X86_32

Signed-off-by: Vishal Verma <vishal.l.verma at intel.com>
---
 drivers/block/nvme-scsi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index d5b3afe..483af35 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -2188,7 +2188,7 @@ static int nvme_trans_io(struct nvme_ns *ns, struct sg_io_hdr *hdr, u8 is_write,
 	xfer_bytes = min(((u64)hdr->dxfer_len), sum_iov_len);
 
 	/* If block count and actual data buffer size dont match, error out */
-	if ((xfer_bytes / (1 << ns->lba_shift)) != cdb_info.xfer_len) {
+	if (xfer_bytes != (cdb_info.xfer_len << ns->lba_shift)) {
 		res = -EINVAL;
 		goto out;
 	}
-- 
1.7.0.4

             reply	other threads:[~2013-03-28 18:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 18:42 Vishal Verma [this message]
2013-03-28 18:49 ` [PATCH] NVMe: Fix a build error for u64 division Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364496170-27921-1-git-send-email-vishal.l.verma@intel.com \
    --to=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).