* [PATCH] NVMe: Fix a signedness bug in nvme_trans_modesel_get_mp
@ 2013-05-13 20:55 Vishal Verma
2013-05-17 13:41 ` Matthew Wilcox
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Verma @ 2013-05-13 20:55 UTC (permalink / raw)
nvme_trans_modesel_get_mp() was defined with a unsigned return
type, but can return signed values.
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Vishal Verma <vishal.l.verma at linux.intel.com>
---
drivers/block/nvme-scsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index fed54b0..b08639a 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -1654,7 +1654,7 @@ static void nvme_trans_modesel_save_bd(struct nvme_ns *ns, u8 *parm_list,
}
}
-static u16 nvme_trans_modesel_get_mp(struct nvme_ns *ns, struct sg_io_hdr *hdr,
+static int nvme_trans_modesel_get_mp(struct nvme_ns *ns, struct sg_io_hdr *hdr,
u8 *mode_page, u8 page_code)
{
int res = SNTI_TRANSLATION_SUCCESS;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-17 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13 20:55 [PATCH] NVMe: Fix a signedness bug in nvme_trans_modesel_get_mp Vishal Verma
2013-05-17 13:41 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).