linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv3 0/5] NVMe: Power management patch set
Date: Mon, 24 Jun 2013 14:30:54 -0600	[thread overview]
Message-ID: <1372105859-27850-1-git-send-email-keith.busch@intel.com> (raw)

This adds power management to the NVMe devices.

I ran this on some real devices and found some errors from the previous
patch that could occur if the resume fails, but not many changes from
the previous set.

v2->v3:

Hand merge to latest head.

Additional checks when releasing the pci resources in case it happens
twice. This could occur if the module is unloaded after the device
failed to initialize on resume.

If the resume fails, free all the queues and check for a null queue
before issuing IO so that IO can not be sent to the block device if the
controller failed to re-initialize. I tried deleting the gendisks too,
but resume never completed when an error was forced with that code. Not
entirely sure why that happened.

Additional error checking on ioremap.

Use SIMPLE_DEV_PM_OPS instead of UNIVERSAL_DEV_PM_OPS. I don't think we
want to use these for runtime suspend/resume on an NVMe device.

Keith Busch (5):
  NVMe: Group pci related actions in functions
  NVMe: Separate queue alloc/free from create/delete
  NVMe: Separate controller init from disk discovery
  NVMe: Use normal shutdown
  NVMe: Add pci suspend/resume driver callbacks

 drivers/block/nvme-core.c |  408 +++++++++++++++++++++++++++++++--------------
 include/linux/nvme.h      |    2 +
 2 files changed, 287 insertions(+), 123 deletions(-)

             reply	other threads:[~2013-06-24 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 20:30 Keith Busch [this message]
2013-06-24 20:30 ` [PATCHv3 1/5] NVMe: Group pci related actions in functions Keith Busch
2013-06-24 20:30 ` [PATCHv3 2/5] NVMe: Separate queue alloc/free from create/delete Keith Busch
2013-06-24 20:30 ` [PATCHv3 3/5] NVMe: Separate controller init from disk discovery Keith Busch
2013-06-24 20:30 ` [PATCHv3 4/5] NVMe: Use normal shutdown Keith Busch
2013-06-24 20:30 ` [PATCHv3 5/5] NVMe: Add pci suspend/resume driver callbacks Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372105859-27850-1-git-send-email-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).