From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 3/4] nvme-pci: add device coredump support
Date: Sat, 4 May 2019 23:46:12 +0900 [thread overview]
Message-ID: <13a4ec6d-e586-3879-d883-33bdbf90f294@gmail.com> (raw)
In-Reply-To: <d0de1c5d-1168-086c-cc16-7d33fd307cd3@gmail.com>
On 5/4/19 11:38 PM, Minwoo Im wrote:
> On 5/4/19 11:26 PM, Akinobu Mita wrote:
>> 2019?5?4?(?) 19:04 Minwoo Im <minwoo.im.dev at gmail.com>:
>>>> +???? { NVME_REG_INTMS,?????? "intms",??????? 32 },
>>>> +???? { NVME_REG_INTMC,?????? "intmc",??????? 32 },
>>>> +???? { NVME_REG_CC,????????? "cc",?????????? 32 },
>>>> +???? { NVME_REG_CSTS,??????? "csts",???????? 32 },
>>>> +???? { NVME_REG_NSSR,??????? "nssr",???????? 32 },
>>>> +???? { NVME_REG_AQA,???????? "aqa",????????? 32 },
>>>> +???? { NVME_REG_ASQ,???????? "asq",????????? 64 },
>>>> +???? { NVME_REG_ACQ,???????? "acq",????????? 64 },
>>>> +???? { NVME_REG_CMBLOC,????? "cmbloc",?????? 32 },
>>>> +???? { NVME_REG_CMBSZ,?????? "cmbsz",??????? 32 },
>>>
>>> If it's going to support optional registers also, then we can have
>>> BP-related things (BPINFO, BPRSEL, BPMBL) here also.
>>
>> I'm going to change the register dump in binary format just like
>> 'nvme show-regs -o binary' does.? So we'll have registers from 00h to
>> 4Fh.
>>
>
> Got it.
>
> And now I can see those two commands `nvme show-regs` and
> `nvme show-regs -o binary` have different results for the register
> range.? The binary output covers just 0x50 size, but it shows all the
> registers including BP-related things in normal && json format.
>
> Anyway, I'll prepare a patch for nvme-cli to support binary output
> format to cover BP things also.
>
> Thanks, for your reply.
My bad, I misunderstood what you have said above. Please ignore
what I mentioned. BP things are located from 40h. to 4Fh.
Sorry for making noises here. ;)
next prev parent reply other threads:[~2019-05-04 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 8:59 [PATCH 0/4] nvme-pci: support device coredump Akinobu Mita
2019-05-02 8:59 ` [PATCH 1/4] devcoredump: use memory_read_from_buffer Akinobu Mita
2019-05-02 12:42 ` Johannes Berg
2019-05-02 8:59 ` [PATCH 2/4] devcoredump: allow to create several coredump files in one device Akinobu Mita
2019-05-02 12:47 ` Johannes Berg
2019-05-03 3:41 ` Akinobu Mita
2019-05-02 8:59 ` [PATCH 3/4] nvme-pci: add device coredump support Akinobu Mita
2019-05-04 10:04 ` Minwoo Im
2019-05-04 14:26 ` Akinobu Mita
2019-05-04 14:38 ` Minwoo Im
2019-05-04 14:46 ` Minwoo Im [this message]
2019-05-02 8:59 ` [PATCH 4/4] nvme-pci: trigger device coredump before resetting controller Akinobu Mita
2019-05-02 12:57 ` [PATCH 0/4] nvme-pci: support device coredump Keith Busch
2019-05-03 3:38 ` Akinobu Mita
2019-05-03 12:12 ` Keith Busch
2019-05-03 12:20 ` Christoph Hellwig
2019-05-04 4:20 ` Akinobu Mita
2019-05-04 9:40 ` Minwoo Im
2019-05-04 14:36 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a4ec6d-e586-3879-d883-33bdbf90f294@gmail.com \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox