From: vishal.l.verma@intel.com (Verma, Vishal L)
Subject: [PATCH 2/2] NVMe: Fix SG_IO status values
Date: Wed, 27 Aug 2014 20:52:53 +0000 [thread overview]
Message-ID: <1409172776.27227.1.camel@omniknight.lm.intel.com> (raw)
In-Reply-To: <1409169339-9821-2-git-send-email-keith.busch@intel.com>
On Wed, 2014-08-27@13:55 -0600, Keith Busch wrote:
> We've only been setting the sg_io_hdr status values on SCSI commands
> that require an nvme command to complete the translation. The fields
> in the struct are output parameters, so we have to set them, otherwise
> user space will see whatever was in memory from before. In the case of
> compat SG_IO, this would reveal kernel memory. This fixes the issue by
> initializing the sg_io_hdr with successful status.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme-scsi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Vishal Verma <vishal.l.verma at linux.intel.com>
prev parent reply other threads:[~2014-08-27 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 19:55 [PATCH 1/2] NVMe: Remove duplicate compat SG_IO code Keith Busch
2014-08-27 19:55 ` [PATCH 2/2] NVMe: Fix SG_IO status values Keith Busch
2014-08-27 20:52 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409172776.27227.1.camel@omniknight.lm.intel.com \
--to=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox