From: vishal.l.verma@intel.com (Verma, Vishal L)
Subject: [PATCH] NVMe: Fix scsi mode select llbaa setting
Date: Mon, 12 Jan 2015 19:04:22 +0000 [thread overview]
Message-ID: <1421089462.23334.3.camel@intel.com> (raw)
In-Reply-To: <1420849240-2259-1-git-send-email-keith.busch@intel.com>
On Fri, 2015-01-09@17:20 -0700, Keith Busch wrote:
> It should be a logical bitwise AND, not conditional.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Vishal Verma <vishal.l.verma at linux.intel.com>
Thanks, good catch!
> diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
> index 046ae33..63efe40 100644
> --- a/drivers/block/nvme-scsi.c
> +++ b/drivers/block/nvme-scsi.c
> @@ -1600,7 +1600,7 @@ static inline void nvme_trans_modesel_get_bd_len(u8 *parm_list, u8 cdb10,
> /* 10 Byte CDB */
> *bd_len = (parm_list[MODE_SELECT_10_BD_OFFSET] << 8) +
> parm_list[MODE_SELECT_10_BD_OFFSET + 1];
> - *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &&
> + *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &
> MODE_SELECT_10_LLBAA_MASK;
> } else {
> /* 6 Byte CDB */
prev parent reply other threads:[~2015-01-12 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 0:20 [PATCH] NVMe: Fix scsi mode select llbaa setting Keith Busch
2015-01-12 19:04 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421089462.23334.3.camel@intel.com \
--to=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox