From: mlin@kernel.org (Ming Lin)
Subject: [RFC] Multi level NVMe stack
Date: Tue, 18 Aug 2015 16:11:49 -0700 [thread overview]
Message-ID: <1439939509.30705.17.camel@ssi> (raw)
In-Reply-To: <CAF1ivSaK_G_ukWeEv0c07WG0s2BieA7JPJD_DfzmGpORvj8qWQ@mail.gmail.com>
On Fri, 2015-07-31@10:04 -0700, Ming Lin wrote:
> On Thu, Jul 30, 2015@7:52 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Wed, Jul 29, 2015@04:55:18PM -0700, Ming Lin wrote:
> >> I'm working on a virtio-nvme driver.
> >> NVMe over Fabrics initiator will probably be available some time.
> >>
> >> I wonder does it make sense to have a multi level NVMe stack(similar as
> >> SCSI). So we can re-use the NVMe core code.
> >
> > Hi Ming,
> >
> > I've put some work in for abstraction, see the work to submit the
> > internal NVMe command through struct request.
> >
> > Once we actually get other transports we can split main data structures,
> > and move the parts sitting above that abstraction out into a separate
> > module.
> >
> > From both looking at the I/O code I'd prefer not to add any abstractions
> > in the I/O code for.
> >
> > I'd suggest you prototype the code without big refactoring first,
> > and then compare your implementation against the NVMe virtualization
> > extensions from Google and check if it's worth it:
> >
> > http://lists.infradead.org/pipermail/linux-nvme/2014-July/001076.html
>
> I'll prototype the code.
So here is the super draft prototype code.
It's basically modified from linux/nvme-core.c and qemu/nvme.c.
http://minggr.noip.me/cgit/cgit.cgi/linux/log/?h=virtio-nvme/prototype
http://minggr.noip.me/cgit/cgit.cgi/qemu/log/?h=virtio-nvme/prototype
I haven't tried Google extensions yet.
A quick comparison with qemu-nvme:
qemu-nvme qemu-virtio-nvme
4k read: 95.7MB/s 105.3MB/s +10%
4k write: 90.2MB/s 96.3MB/s +6.7%
I'll post the patches after I make it in good shape and do more
optimizations.
prev parent reply other threads:[~2015-08-18 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 23:55 [RFC] Multi level NVMe stack Ming Lin
2015-07-30 14:52 ` Christoph Hellwig
2015-07-31 17:04 ` Ming Lin
2015-08-18 23:11 ` Ming Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439939509.30705.17.camel@ssi \
--to=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox