linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mlin@kernel.org (Ming Lin)
Subject: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same}
Date: Wed, 21 Oct 2015 08:01:19 -0700	[thread overview]
Message-ID: <1445439679.3126.5.camel@hasee> (raw)
In-Reply-To: <x49io60wdap.fsf@segfault.boston.devel.redhat.com>

On Wed, 2015-10-21@09:39 -0400, Jeff Moyer wrote:
> Christoph Hellwig <hch at infradead.org> writes:
> 
> > Jens, Ming:
> >
> > are you fine with the one liner change to get back to the old I/O
> > pattern?  While it looks like the cards fault I'd like to avoid this
> > annoying regression.
> 
> I'm not Jens or Ming, but your patch looks fine to me, though you'll
> want to remove the MAX_BIO_SECTORS definition since it's now unused.
> It's not clear to me why the limit was lowered in the first place.

UINT_MAX >> 9 is not power of 2 and it causes dm-thinp discard fails.

At the lengthy discussion:
[PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
We agreed to cap discard to 2G as an interim solution for 4.3 until the
dm-thinp discard code is rewritten.

Hi Mike,

Will the dm-thinp discard rewritten ready for 4.4?

Thanks,
Ming

> 
> You can add my Reviewed-by: Jeff Moyer <jmoyer at redhat.com> if you resend
> the patch.
> 
> -Jeff

  reply	other threads:[~2015-10-21 15:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1439363241-31772-1-git-send-email-mlin@kernel.org>
     [not found] ` <1439363241-31772-6-git-send-email-mlin@kernel.org>
2015-10-13 11:50   ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Christoph Hellwig
2015-10-13 17:44     ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard, write_same} Ming Lin
2015-10-14 13:27       ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Christoph Hellwig
2015-10-14 16:38         ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same}B Keith Busch
2015-10-14 16:50           ` Christoph Hellwig
2015-10-21 16:02         ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Mike Snitzer
2015-10-21 16:19           ` Mike Snitzer
2015-10-21 16:33             ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard, write_same} Martin K. Petersen
2015-10-21 17:33             ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Ming Lin
2015-10-21 18:18               ` Mike Snitzer
2015-10-21 20:13                 ` Ming Lin
2015-10-22 10:24                   ` Christoph Hellwig
2015-10-22 11:22                     ` Christoph Hellwig
2015-10-21  7:21       ` Christoph Hellwig
2015-10-21 13:39         ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard, write_same} Jeff Moyer
2015-10-21 15:01           ` Ming Lin [this message]
2015-10-21 15:33             ` [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Mike Snitzer
2015-10-21 17:18               ` Ming Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445439679.3126.5.camel@hasee \
    --to=mlin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).