From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/4] NVMe: Fix io incapable return values
Date: Wed, 3 Feb 2016 09:05:40 -0700 [thread overview]
Message-ID: <1454515543-21683-2-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1454515543-21683-1-git-send-email-keith.busch@intel.com>
The function returns true when the controller can't handle IO.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/nvme.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 4fb5bb7..9664d07 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -139,9 +139,9 @@ static inline bool nvme_io_incapable(struct nvme_ctrl *ctrl)
u32 val = 0;
if (ctrl->ops->io_incapable(ctrl))
- return false;
+ return true;
if (ctrl->ops->reg_read32(ctrl, NVME_REG_CSTS, &val))
- return false;
+ return true;
return val & NVME_CSTS_CFS;
}
--
2.6.2.307.g37023ba
next prev parent reply other threads:[~2016-02-03 16:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 16:05 [PATCH 0/4] NVMe: Surprise removal fixes Keith Busch
2016-02-03 16:05 ` Keith Busch [this message]
2016-02-04 15:55 ` [PATCH 1/4] NVMe: Fix io incapable return values Sagi Grimberg
2016-02-08 18:10 ` Christoph Hellwig
2016-02-03 16:05 ` [PATCH 2/4] NVMe: Sync stopped queues with block layer Keith Busch
2016-02-04 15:57 ` Sagi Grimberg
2016-02-04 16:00 ` Keith Busch
2016-02-08 18:11 ` Christoph Hellwig
2016-02-03 16:05 ` [PATCH 3/4] NVMe: Surprise removal fixes Keith Busch
2016-02-08 18:16 ` Christoph Hellwig
2016-02-08 18:38 ` Keith Busch
2016-02-08 23:48 ` Keith Busch
2016-02-03 16:05 ` [PATCH 4/4] blk-mq: End unstarted requests on dying queue Keith Busch
2016-02-04 15:59 ` Sagi Grimberg
2016-02-08 18:13 ` Christoph Hellwig
2016-02-04 3:25 ` [PATCH 0/4] NVMe: Surprise removal fixes Wenbo Wang
2016-02-04 15:52 ` Keith Busch
2016-02-04 15:55 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454515543-21683-2-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).