From: mlin@kernel.org (Ming Lin)
Subject: [PATCH RFC] nvme: rewrite discard support
Date: Thu, 17 Mar 2016 10:27:23 -0700 [thread overview]
Message-ID: <1458235643.11458.2.camel@ssi> (raw)
In-Reply-To: <20160317153335.GB6217@localhost.lm.intel.com>
On Thu, 2016-03-17@15:33 +0000, Keith Busch wrote:
> On Wed, Mar 16, 2016@04:15:32PM -0700, Ming Lin wrote:
> > From: Ming Lin <ming.l at ssi.samsung.com>
> >
> > This rewrites nvme_setup_discard() similar as sd_setup_discard_cmnd().
> > And moves it to common code so fabrics driver can also use it.
>
> Initial thoughts on this, I see the appeal to having a generic NVMe
> discard setup, but I liked the existing implementation not needing a
> special case for discard check on every IO in the completion handler.
>
> Allocating a page for just 16 bytes of data seems a bit wasteful even
> if it is short-lived. When it was allocating 256b from the DMA pool,
> the smaller amount of additional data seemed worth it for not creating
> a conditional completion.
How about moving the prp_small_pool to the core(and rename it to
nvme_small_pool)?
Then DISCARD can also use this pool. So we don't need a special case
check in the completion handler.
next prev parent reply other threads:[~2016-03-17 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 23:15 [PATCH RFC] nvme: rewrite discard support Ming Lin
2016-03-17 15:33 ` Keith Busch
2016-03-17 17:27 ` Ming Lin [this message]
2016-03-21 14:47 ` Christoph Hellwig
2016-03-21 15:51 ` Keith Busch
2016-03-21 15:57 ` Christoph Hellwig
2016-03-21 16:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458235643.11458.2.camel@ssi \
--to=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox